2020-08-18 08:16:30

by Qingyu Li

[permalink] [raw]
Subject: [PATCH] net/bluetooth/cmtp/sock.c: add CAP_NET_RAW check.

When creating a raw PF_BLUETOOTH socket,
CAP_NET_RAW needs to be checked first.

Signed-off-by: Qingyu Li <[email protected]>
---
net/bluetooth/cmtp/sock.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/net/bluetooth/cmtp/sock.c b/net/bluetooth/cmtp/sock.c
index 96d49d9fae96..476ccc9bee7c 100644
--- a/net/bluetooth/cmtp/sock.c
+++ b/net/bluetooth/cmtp/sock.c
@@ -207,6 +207,9 @@ static int cmtp_sock_create(struct net *net, struct socket *sock, int protocol,
if (sock->type != SOCK_RAW)
return -ESOCKTNOSUPPORT;

+ if (!capable(CAP_NET_RAW))
+ return -EPERM;
+
sk = sk_alloc(net, PF_BLUETOOTH, GFP_ATOMIC, &cmtp_proto, kern);
if (!sk)
return -ENOMEM;
--
2.17.1


2020-08-18 18:31:25

by Jesse Brandeburg

[permalink] [raw]
Subject: Re: [PATCH] net/bluetooth/cmtp/sock.c: add CAP_NET_RAW check.

On Tue, 18 Aug 2020 16:15:55 +0800
Qingyu Li <[email protected]> wrote:

> When creating a raw PF_BLUETOOTH socket,
> CAP_NET_RAW needs to be checked first.

Please see my previous replies.