2021-07-29 16:45:46

by Michael Sun

[permalink] [raw]
Subject: [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers

From: Chethan T N <[email protected]>

The Intel TyphoonPeak, GarfieldPeak Bluetooth controllers
support the Microsoft vendor extension and they are using
0xFC1E for VsMsftOpCode.

Verified on a GarfieldPeak device through bluetoothctl show

Signed-off-by: Chethan T N <[email protected]>
Signed-off-by: Michael Sun <[email protected]>
---

drivers/bluetooth/btusb.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 1876a960b3dc..23cf6e98173b 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3031,6 +3031,17 @@ static int btusb_setup_intel_newgen(struct hci_dev *hdev)
btintel_version_info_tlv(hdev, &version);

finish:
+ /* All Intel new genration controllers support the Microsoft vendor
+ * extension are using 0xFC1E for VsMsftOpCode.
+ */
+ switch (INTEL_HW_VARIANT(version.cnvi_bt)) {
+ case 0x17:
+ case 0x18:
+ case 0x19:
+ hci_set_msft_opcode(hdev, 0xFC1E);
+ break;
+ }
+
/* Set the event mask for Intel specific vendor events. This enables
* a few extra events that are useful during general operation. It
* does not enable any debugging related events.
--
2.32.0.432.gabb21c7263-goog



2021-07-29 17:32:47

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=523533

---Test result---

Test Summary:
CheckPatch PASS 0.67 seconds
GitLint FAIL 0.10 seconds
BuildKernel PASS 516.58 seconds
TestRunner: Setup PASS 339.96 seconds
TestRunner: l2cap-tester PASS 2.52 seconds
TestRunner: bnep-tester PASS 1.92 seconds
TestRunner: mgmt-tester PASS 30.68 seconds
TestRunner: rfcomm-tester PASS 2.12 seconds
TestRunner: sco-tester PASS 2.05 seconds
TestRunner: smp-tester FAIL 2.11 seconds
TestRunner: userchan-tester PASS 1.95 seconds

Details
##############################
Test: CheckPatch - PASS - 0.67 seconds
Run checkpatch.pl script with rule in .checkpatch.conf


##############################
Test: GitLint - FAIL - 0.10 seconds
Run gitlint with rule in .gitlint
Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers
1: T1 Title exceeds max length (77>72): "Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers"


##############################
Test: BuildKernel - PASS - 516.58 seconds
Build Kernel with minimal configuration supports Bluetooth


##############################
Test: TestRunner: Setup - PASS - 339.96 seconds
Setup environment for running Test Runner


##############################
Test: TestRunner: l2cap-tester - PASS - 2.52 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: bnep-tester - PASS - 1.92 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: mgmt-tester - PASS - 30.68 seconds
Run test-runner with mgmt-tester
Total: 448, Passed: 445 (99.3%), Failed: 0, Not Run: 3

##############################
Test: TestRunner: rfcomm-tester - PASS - 2.12 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: sco-tester - PASS - 2.05 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: smp-tester - FAIL - 2.11 seconds
Run test-runner with smp-tester
Total: 8, Passed: 7 (87.5%), Failed: 1, Not Run: 0

Failed Test Cases
SMP Client - SC Request 2 Failed 0.022 seconds

##############################
Test: TestRunner: userchan-tester - PASS - 1.95 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth


Attachments:
l2cap-tester.log (43.35 kB)
bnep-tester.log (3.51 kB)
mgmt-tester.log (602.41 kB)
rfcomm-tester.log (11.44 kB)
sco-tester.log (9.71 kB)
smp-tester.log (11.47 kB)
userchan-tester.log (5.36 kB)
Download all attachments

2021-07-29 19:48:24

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers

Hi Michael,

> The Intel TyphoonPeak, GarfieldPeak Bluetooth controllers
> support the Microsoft vendor extension and they are using
> 0xFC1E for VsMsftOpCode.
>
> Verified on a GarfieldPeak device through bluetoothctl show
>
> Signed-off-by: Chethan T N <[email protected]>
> Signed-off-by: Michael Sun <[email protected]>
> ---
>
> drivers/bluetooth/btusb.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)

Patch has been applied to bluetooth-next tree.

Regards

Marcel