2021-10-06 02:43:05

by Tedd Ho-Jeong An

Subject: [BlueZ PATCH] tools/mgmt-tester: Update the correct suspend reason for disconnect

From: Tedd Ho-Jeong An <[email protected]>

This patch fixes the suspend reason for the pairing test cases to the
disconnect.
---
tools/mgmt-tester.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
index 611bf3dbf..1a2aba7fd 100644
--- a/tools/mgmt-tester.c
+++ b/tools/mgmt-tester.c
@@ -10414,10 +10414,6 @@ static void test_50_controller_cap_response(const void *test_data)
data, NULL);
}

-static const uint8_t suspend_state_param_running[] = {
- 0x00,
-};
-
static const uint8_t suspend_state_param_disconnect[] = {
0x01,
};
@@ -10587,8 +10583,8 @@ static const struct generic_data suspend_resume_success_5 = {
.client_pin = pair_device_pin,
.client_pin_len = sizeof(pair_device_pin),
.expect_alt_ev = MGMT_EV_CONTROLLER_SUSPEND,
- .expect_alt_ev_param = suspend_state_param_running,
- .expect_alt_ev_len = sizeof(suspend_state_param_running),
+ .expect_alt_ev_param = suspend_state_param_disconnect,
+ .expect_alt_ev_len = sizeof(suspend_state_param_disconnect),
};

static void trigger_force_suspend(void *user_data)
@@ -10616,8 +10612,8 @@ static const struct generic_data suspend_resume_success_6 = {
.setup_settings = settings_powered_connectable_bondable_ssp,
.client_enable_ssp = true,
.expect_alt_ev = MGMT_EV_CONTROLLER_SUSPEND,
- .expect_alt_ev_param = suspend_state_param_running,
- .expect_alt_ev_len = sizeof(suspend_state_param_running),
+ .expect_alt_ev_param = suspend_state_param_disconnect,
+ .expect_alt_ev_len = sizeof(suspend_state_param_disconnect),
.expect_hci_command = BT_HCI_CMD_USER_CONFIRM_REQUEST_REPLY,
.expect_hci_func = client_bdaddr_param_func,
.io_cap = 0x03, /* NoInputNoOutput */
--
2.25.1

2021-10-06 03:05:03

by bluez.test.bot

Subject: RE: [BlueZ] tools/mgmt-tester: Update the correct suspend reason for disconnect

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=558253

---Test result---

Test Summary:
CheckPatch PASS 1.42 seconds
GitLint PASS 0.92 seconds
Prep - Setup ELL PASS 47.11 seconds
Build - Prep PASS 0.50 seconds
Build - Configure PASS 9.03 seconds
Build - Make PASS 201.78 seconds
Make Check PASS 9.71 seconds
Make Distcheck PASS 238.39 seconds
Build w/ext ELL - Configure PASS 8.76 seconds
Build w/ext ELL - Make PASS 190.52 seconds



---
Regards,
Linux Bluetooth

2021-10-06 18:00:30

by Luiz Augusto von Dentz

Subject: Re: [BlueZ] tools/mgmt-tester: Update the correct suspend reason for disconnect

Hi Tedd,

On Tue, Oct 5, 2021 at 8:05 PM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=558253
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 1.42 seconds
> GitLint PASS 0.92 seconds
> Prep - Setup ELL PASS 47.11 seconds
> Build - Prep PASS 0.50 seconds
> Build - Configure PASS 9.03 seconds
> Build - Make PASS 201.78 seconds
> Make Check PASS 9.71 seconds
> Make Distcheck PASS 238.39 seconds
> Build w/ext ELL - Configure PASS 8.76 seconds
> Build w/ext ELL - Make PASS 190.52 seconds
>
>
>
> ---
> Regards,
> Linux Bluetooth

Applied, thanks.

--
Luiz Augusto von Dentz