dbus_message_iter_recurse only makese sense for container types, this is a string.
Fixes: https://github.com/bluez/bluez/issues/300
---
plugins/neard.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/plugins/neard.c b/plugins/neard.c
index a75527148..99762482c 100644
--- a/plugins/neard.c
+++ b/plugins/neard.c
@@ -575,14 +575,12 @@ static int process_message(DBusMessage *msg, struct oob_params *remote)
if (process_nokia_com_bt(data, size, remote))
goto error;
} else if (strcasecmp(key, "State") == 0) {
- DBusMessageIter array;
const char *state;
if (dbus_message_iter_get_arg_type(&value) !=
DBUS_TYPE_STRING)
goto error;
- dbus_message_iter_recurse(&value, &array);
dbus_message_iter_get_basic(&value, &state);
remote->power_state = process_state(state);
--
2.35.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=617325
---Test result---
Test Summary:
CheckPatch FAIL 1.51 seconds
GitLint FAIL 1.03 seconds
Prep - Setup ELL PASS 53.57 seconds
Build - Prep PASS 0.79 seconds
Build - Configure PASS 10.69 seconds
Build - Make PASS 1531.03 seconds
Make Check PASS 12.69 seconds
Make Check w/Valgrind PASS 536.98 seconds
Make Distcheck PASS 285.06 seconds
Build w/ext ELL - Configure PASS 10.59 seconds
Build w/ext ELL - Make PASS 1478.81 seconds
Incremental Build with patchesPASS 0.00 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ] neard: Fix reading State message
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#71:
dbus_message_iter_recurse only makese sense for container types, this is a string.
/github/workspace/src/12757527.patch total: 0 errors, 1 warnings, 14 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12757527.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
[BlueZ] neard: Fix reading State message
3: B1 Line exceeds max length (82>80): "dbus_message_iter_recurse only makese sense for container types, this is a string."
---
Regards,
Linux Bluetooth