From: Luiz Augusto von Dentz <[email protected]>
This treats empty LocalName ("") the same as omitting it so not name is
set in the advertising data since some D-Bus binding seems to have
problems to omit properties at runtime.
Fixes: https://github.com/bluez/bluez/issues/337
---
src/advertising.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/advertising.c b/src/advertising.c
index 2110f17c9..ca23774ba 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -533,7 +533,15 @@ static bool parse_local_name(DBusMessageIter *iter,
dbus_message_iter_get_basic(iter, &name);
free(client->name);
- client->name = strdup(name);
+
+ /* Treat empty string the same as omitting since there is no point on
+ * adding a empty name as AD data as it just take space that could be
+ * used for something else.
+ */
+ if (name[0] != '\0')
+ client->name = strdup(name);
+ else
+ client->name = NULL;
return true;
}
--
2.35.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=639269
---Test result---
Test Summary:
CheckPatch PASS 1.47 seconds
GitLint PASS 1.00 seconds
Prep - Setup ELL PASS 39.50 seconds
Build - Prep PASS 0.67 seconds
Build - Configure PASS 8.10 seconds
Build - Make PASS 1368.00 seconds
Make Check PASS 11.37 seconds
Make Check w/Valgrind PASS 405.40 seconds
Make Distcheck PASS 213.47 seconds
Build w/ext ELL - Configure PASS 7.93 seconds
Build w/ext ELL - Make PASS 1380.64 seconds
Incremental Build with patchesPASS 0.00 seconds
---
Regards,
Linux Bluetooth
Hello:
This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:
On Fri, 6 May 2022 16:08:19 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> This treats empty LocalName ("") the same as omitting it so not name is
> set in the advertising data since some D-Bus binding seems to have
> problems to omit properties at runtime.
>
> Fixes: https://github.com/bluez/bluez/issues/337
>
> [...]
Here is the summary with links:
- [BlueZ] advertising: Treat empty LocalName the same as omitting it
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f0106d92a1e0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html