From: Luiz Augusto von Dentz <[email protected]>
HCI_CONN_FLAG_REMOTE_WAKEUP can only be set if device can be programmed
in the allowlist which in case of device using RPA requires LL Privacy
support to be enabled.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215768
Signed-off-by: Luiz Augusto von Dentz <[email protected]>
---
net/bluetooth/mgmt.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index d2d390534e54..74937a834648 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -4529,6 +4529,23 @@ static int set_device_flags(struct sock *sk, struct hci_dev *hdev, void *data,
params = hci_conn_params_lookup(hdev, &cp->addr.bdaddr,
le_addr_type(cp->addr.type));
if (params) {
+ DECLARE_BITMAP(flags, __HCI_CONN_NUM_FLAGS);
+
+ bitmap_from_u64(flags, current_flags);
+
+ /* Devices using RPAs can only be programmed in the
+ * acceptlist LL Privacy has been enable otherwise they
+ * cannot mark HCI_CONN_FLAG_REMOTE_WAKEUP.
+ */
+ if (test_bit(HCI_CONN_FLAG_REMOTE_WAKEUP, flags) &&
+ !use_ll_privacy(hdev) &&
+ hci_find_irk_by_addr(hdev, ¶ms->addr,
+ params->addr_type)) {
+ bt_dev_warn(hdev,
+ "Cannot set wakeable for RPA");
+ goto unlock;
+ }
+
bitmap_from_u64(params->flags, current_flags);
status = MGMT_STATUS_SUCCESS;
@@ -4545,6 +4562,7 @@ static int set_device_flags(struct sock *sk, struct hci_dev *hdev, void *data,
}
}
+unlock:
hci_dev_unlock(hdev);
done:
--
2.35.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=641172
---Test result---
Test Summary:
CheckPatch PASS 3.22 seconds
GitLint FAIL 1.88 seconds
SubjectPrefix PASS 1.70 seconds
BuildKernel PASS 30.90 seconds
BuildKernel32 PASS 27.89 seconds
Incremental Build with patchesPASS 44.22 seconds
TestRunner: Setup PASS 469.25 seconds
TestRunner: l2cap-tester PASS 17.40 seconds
TestRunner: bnep-tester PASS 6.07 seconds
TestRunner: mgmt-tester PASS 101.55 seconds
TestRunner: rfcomm-tester PASS 9.66 seconds
TestRunner: sco-tester PASS 9.48 seconds
TestRunner: smp-tester PASS 9.49 seconds
TestRunner: userchan-tester PASS 6.37 seconds
Details
##############################
Test: GitLint - FAIL - 1.88 seconds
Run gitlint with rule in .gitlint
[v2,2/2] Bluetooth: hci_sync: Fix attempting to suspend with unfiltered passive scan
1: T1 Title exceeds max length (84>80): "[v2,2/2] Bluetooth: hci_sync: Fix attempting to suspend with unfiltered passive scan"
---
Regards,
Linux Bluetooth
Hello:
This series was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <[email protected]>:
On Thu, 12 May 2022 15:31:33 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> HCI_CONN_FLAG_REMOTE_WAKEUP can only be set if device can be programmed
> in the allowlist which in case of device using RPA requires LL Privacy
> support to be enabled.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215768
> Signed-off-by: Luiz Augusto von Dentz <[email protected]>
>
> [...]
Here is the summary with links:
- [v2,1/2] Bluetooth: MGMT: Add conditions for setting HCI_CONN_FLAG_REMOTE_WAKEUP
https://git.kernel.org/bluetooth/bluetooth-next/c/a9a347655d22
- [v2,2/2] Bluetooth: hci_sync: Fix attempting to suspend with unfiltered passive scan
https://git.kernel.org/bluetooth/bluetooth-next/c/3b42055388c3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html