2022-07-13 14:25:48

by Yuri D'Elia

[permalink] [raw]
Subject: [PATCH] Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for MTK

This sets HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for MTK controllers
since SCO appear to not work when using HCI_OP_ENHANCED_SETUP_SYNC_CONN.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=215576
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index e25fcd49db..d5da862fab 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3795,6 +3795,7 @@ static int btusb_probe(struct usb_interface *intf,
hdev->manufacturer = 70;
hdev->cmd_timeout = btusb_mtk_cmd_timeout;
hdev->set_bdaddr = btmtk_set_bdaddr;
+ set_bit(HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN, &hdev->quirks);
set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
data->recv_acl = btusb_recv_acl_mtk;
}
--
2.36.1


2022-07-13 15:11:09

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for MTK

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=659355

---Test result---

Test Summary:
CheckPatch FAIL 1.03 seconds
GitLint PASS 0.47 seconds
SubjectPrefix PASS 0.29 seconds
BuildKernel PASS 38.41 seconds
BuildKernel32 PASS 34.29 seconds
Incremental Build with patchesPASS 44.56 seconds
TestRunner: Setup PASS 563.69 seconds
TestRunner: l2cap-tester PASS 18.75 seconds
TestRunner: bnep-tester PASS 6.63 seconds
TestRunner: mgmt-tester PASS 108.37 seconds
TestRunner: rfcomm-tester PASS 10.53 seconds
TestRunner: sco-tester PASS 9.90 seconds
TestRunner: smp-tester PASS 9.95 seconds
TestRunner: userchan-tester PASS 6.78 seconds

Details
##############################
Test: CheckPatch - FAIL - 1.03 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for MTK\ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12916835.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth

2022-07-13 15:37:03

by Yuri D'Elia

[permalink] [raw]
Subject: [PATCH v2] Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for MTK

This sets HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for MTK controllers
since SCO appear to not work when using HCI_OP_ENHANCED_SETUP_SYNC_CONN.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=215576
Signed-off-by: Yuri D'Elia <[email protected]>
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index e25fcd49db..d5da862fab 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3795,6 +3795,7 @@ static int btusb_probe(struct usb_interface *intf,
hdev->manufacturer = 70;
hdev->cmd_timeout = btusb_mtk_cmd_timeout;
hdev->set_bdaddr = btmtk_set_bdaddr;
+ set_bit(HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN, &hdev->quirks);
set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
data->recv_acl = btusb_recv_acl_mtk;
}
--
2.36.1

2022-07-13 16:25:28

by bluez.test.bot

[permalink] [raw]
Subject: RE: [v2] Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for MTK

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=659388

---Test result---

Test Summary:
CheckPatch PASS 1.58 seconds
GitLint PASS 0.74 seconds
SubjectPrefix PASS 0.61 seconds
BuildKernel PASS 40.10 seconds
BuildKernel32 PASS 34.51 seconds
Incremental Build with patchesPASS 47.48 seconds
TestRunner: Setup PASS 590.85 seconds
TestRunner: l2cap-tester PASS 19.21 seconds
TestRunner: bnep-tester PASS 7.11 seconds
TestRunner: mgmt-tester PASS 112.79 seconds
TestRunner: rfcomm-tester PASS 10.82 seconds
TestRunner: sco-tester PASS 10.50 seconds
TestRunner: smp-tester PASS 10.52 seconds
TestRunner: userchan-tester PASS 7.35 seconds



---
Regards,
Linux Bluetooth

2022-07-20 16:26:06

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH v2] Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for MTK

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 13 Jul 2022 17:29:13 +0200 you wrote:
> This sets HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for MTK controllers
> since SCO appear to not work when using HCI_OP_ENHANCED_SETUP_SYNC_CONN.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215576
> Signed-off-by: Yuri D'Elia <[email protected]>
> ---
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)

Here is the summary with links:
- [v2] Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for MTK
https://git.kernel.org/bluetooth/bluetooth-next/c/d8252b94a32a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html