Hold hdev->lock for hci_conn_failed. There are possible race conditions
which may cause kernel crash.
Changes in v3:
- Remove an empty line in commit message between Fixes and SoB
Changes in v2:
- Update commit message
Changes in v1:
- Hold hdev->lock for hci_conn_failed
Zhengping Jiang (1):
Bluetooth: hci_sync: hold hdev->lock when cleanup hci_conn
net/bluetooth/hci_sync.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.37.1.595.g718a3a8f04-goog
When disconnecting all devices, hci_conn_failed is used to cleanup
hci_conn object when the hci_conn object cannot be aborted.
The function hci_conn_failed requires the caller holds hdev->lock.
Fixes: 9b3628d79b46f ("Bluetooth: hci_sync: Cleanup hci_conn if it cannot be aborted")
Signed-off-by: Zhengping Jiang <[email protected]>
---
Changes in v3:
- Remove an empty line in commit message between Fixes and SoB
Changes in v2:
- Update commit message
Changes in v1:
- Hold hdev->lock for hci_conn_failed
net/bluetooth/hci_sync.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 74a0cd5d0b37f..e08c0503027d8 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -5034,9 +5034,11 @@ int hci_abort_conn_sync(struct hci_dev *hdev, struct hci_conn *conn, u8 reason)
/* Cleanup hci_conn object if it cannot be cancelled as it
* likelly means the controller and host stack are out of sync.
*/
- if (err)
+ if (err) {
+ hci_dev_lock(hdev);
hci_conn_failed(conn, err);
-
+ hci_dev_unlock(hdev);
+ }
return err;
case BT_CONNECT2:
return hci_reject_conn_sync(hdev, conn, reason);
--
2.37.1.595.g718a3a8f04-goog
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=670367
---Test result---
Test Summary:
CheckPatch PASS 0.90 seconds
GitLint PASS 0.50 seconds
SubjectPrefix PASS 0.31 seconds
BuildKernel PASS 41.03 seconds
BuildKernel32 PASS 37.01 seconds
Incremental Build with patchesPASS 52.46 seconds
TestRunner: Setup PASS 590.16 seconds
TestRunner: l2cap-tester PASS 19.08 seconds
TestRunner: bnep-tester PASS 7.51 seconds
TestRunner: mgmt-tester PASS 122.65 seconds
TestRunner: rfcomm-tester PASS 12.16 seconds
TestRunner: sco-tester PASS 11.78 seconds
TestRunner: smp-tester PASS 11.16 seconds
TestRunner: userchan-tester PASS 7.64 seconds
---
Regards,
Linux Bluetooth
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:
On Tue, 23 Aug 2022 10:28:07 -0700 you wrote:
> Hold hdev->lock for hci_conn_failed. There are possible race conditions
> which may cause kernel crash.
>
> Changes in v3:
> - Remove an empty line in commit message between Fixes and SoB
>
> Changes in v2:
> - Update commit message
>
> [...]
Here is the summary with links:
- [kernel,v3,1/1] Bluetooth: hci_sync: hold hdev->lock when cleanup hci_conn
https://git.kernel.org/bluetooth/bluetooth-next/c/808765508e8e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html