Fixes: bd0808bf01eb ("client: Add advertise.secondary command")
Fixes: 4e7780d0eb94 ("client/advertising: Add support for setting min/max intervals")
Fixes: 068e0ba214b9 ("client: Add set-advertise-{duration, timeout}")
Fixes: 5c3a39e642d5 ("client: Enable set-advertise-appearance to set Appearance")
Fixes: 177eccc14523 ("client: Enable set-advertise-name to set LocalName")
Fixes: 806276fe54fa ("client: Add advertise.discoverable-timeout command")
Signed-off-by: Christian Eggers <[email protected]>
---
client/advertising.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/client/advertising.c b/client/advertising.c
index 5c9e3eeb3315..837cf817e871 100644
--- a/client/advertising.c
+++ b/client/advertising.c
@@ -329,7 +329,7 @@ static gboolean get_includes(const GDBusPropertyTable *property,
return TRUE;
}
-static gboolean local_name_exits(const GDBusPropertyTable *property, void *data)
+static gboolean local_name_exists(const GDBusPropertyTable *property, void *data)
{
return ad.local_name ? TRUE : FALSE;
}
@@ -342,7 +342,7 @@ static gboolean get_local_name(const GDBusPropertyTable *property,
return TRUE;
}
-static gboolean appearance_exits(const GDBusPropertyTable *property, void *data)
+static gboolean appearance_exists(const GDBusPropertyTable *property, void *data)
{
return ad.local_appearance != UINT16_MAX ? TRUE : FALSE;
}
@@ -356,7 +356,7 @@ static gboolean get_appearance(const GDBusPropertyTable *property,
return TRUE;
}
-static gboolean duration_exits(const GDBusPropertyTable *property, void *data)
+static gboolean duration_exists(const GDBusPropertyTable *property, void *data)
{
return ad.duration;
}
@@ -369,7 +369,7 @@ static gboolean get_duration(const GDBusPropertyTable *property,
return TRUE;
}
-static gboolean timeout_exits(const GDBusPropertyTable *property, void *data)
+static gboolean timeout_exists(const GDBusPropertyTable *property, void *data)
{
return ad.timeout;
}
@@ -420,7 +420,7 @@ static gboolean get_discoverable(const GDBusPropertyTable *property,
return TRUE;
}
-static gboolean discoverable_timeout_exits(const GDBusPropertyTable *property,
+static gboolean discoverable_timeout_exists(const GDBusPropertyTable *property,
void *data)
{
return ad.discoverable_to;
@@ -435,7 +435,7 @@ static gboolean get_discoverable_timeout(const GDBusPropertyTable *property,
return TRUE;
}
-static gboolean secondary_exits(const GDBusPropertyTable *property, void *data)
+static gboolean secondary_exists(const GDBusPropertyTable *property, void *data)
{
return ad.secondary ? TRUE : FALSE;
}
@@ -449,7 +449,7 @@ static gboolean get_secondary(const GDBusPropertyTable *property,
return TRUE;
}
-static gboolean min_interval_exits(const GDBusPropertyTable *property,
+static gboolean min_interval_exists(const GDBusPropertyTable *property,
void *data)
{
return ad.min_interval;
@@ -464,7 +464,7 @@ static gboolean get_min_interval(const GDBusPropertyTable *property,
return TRUE;
}
-static gboolean max_interval_exits(const GDBusPropertyTable *property,
+static gboolean max_interval_exists(const GDBusPropertyTable *property,
void *data)
{
return ad.max_interval;
@@ -488,15 +488,15 @@ static const GDBusPropertyTable ad_props[] = {
{ "Data", "a{yv}", get_data, NULL, data_exists },
{ "Discoverable", "b", get_discoverable, NULL, discoverable_exists },
{ "DiscoverableTimeout", "q", get_discoverable_timeout, NULL,
- discoverable_timeout_exits },
+ discoverable_timeout_exists },
{ "Includes", "as", get_includes, NULL, includes_exists },
- { "LocalName", "s", get_local_name, NULL, local_name_exits },
- { "Appearance", "q", get_appearance, NULL, appearance_exits },
- { "Duration", "q", get_duration, NULL, duration_exits },
- { "Timeout", "q", get_timeout, NULL, timeout_exits },
- { "MinInterval", "u", get_min_interval, NULL, min_interval_exits },
- { "MaxInterval", "u", get_max_interval, NULL, max_interval_exits },
- { "SecondaryChannel", "s", get_secondary, NULL, secondary_exits },
+ { "LocalName", "s", get_local_name, NULL, local_name_exists },
+ { "Appearance", "q", get_appearance, NULL, appearance_exists },
+ { "Duration", "q", get_duration, NULL, duration_exists },
+ { "Timeout", "q", get_timeout, NULL, timeout_exists },
+ { "MinInterval", "u", get_min_interval, NULL, min_interval_exists },
+ { "MaxInterval", "u", get_max_interval, NULL, max_interval_exists },
+ { "SecondaryChannel", "s", get_secondary, NULL, secondary_exists },
{ }
};
--
2.35.3
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=671217
---Test result---
Test Summary:
CheckPatch FAIL 1.46 seconds
GitLint FAIL 0.99 seconds
Prep - Setup ELL PASS 26.56 seconds
Build - Prep PASS 0.84 seconds
Build - Configure PASS 8.48 seconds
Build - Make PASS 830.25 seconds
Make Check PASS 11.36 seconds
Make Check w/Valgrind PASS 289.57 seconds
Make Distcheck PASS 234.18 seconds
Build w/ext ELL - Configure PASS 8.60 seconds
Build w/ext ELL - Make PASS 80.76 seconds
Incremental Build w/ patches PASS 0.00 seconds
Scan Build PASS 482.01 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
client/advertising: Fix typos: *_exits --> *_exists
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'bd0808bf01eb', maybe rebased or not pulled?
#106:
Fixes: bd0808bf01eb ("client: Add advertise.secondary command")
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '4e7780d0eb94', maybe rebased or not pulled?
#107:
Fixes: 4e7780d0eb94 ("client/advertising: Add support for setting min/max intervals")
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '068e0ba214b9', maybe rebased or not pulled?
#108:
Fixes: 068e0ba214b9 ("client: Add set-advertise-{duration, timeout}")
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '5c3a39e642d5', maybe rebased or not pulled?
#109:
Fixes: 5c3a39e642d5 ("client: Enable set-advertise-appearance to set Appearance")
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '177eccc14523', maybe rebased or not pulled?
#110:
Fixes: 177eccc14523 ("client: Enable set-advertise-name to set LocalName")
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '806276fe54fa', maybe rebased or not pulled?
#111:
Fixes: 806276fe54fa ("client: Add advertise.discoverable-timeout command")
WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#126: FILE: client/advertising.c:332:
+static gboolean local_name_exists(const GDBusPropertyTable *property, void *data)
WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#135: FILE: client/advertising.c:345:
+static gboolean appearance_exists(const GDBusPropertyTable *property, void *data)
/github/workspace/src/12955218.patch total: 0 errors, 8 warnings, 87 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12955218.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
client/advertising: Fix typos: *_exits --> *_exists
4: B1 Line exceeds max length (85>80): "Fixes: 4e7780d0eb94 ("client/advertising: Add support for setting min/max intervals")"
6: B1 Line exceeds max length (81>80): "Fixes: 5c3a39e642d5 ("client: Enable set-advertise-appearance to set Appearance")"
---
Regards,
Linux Bluetooth