2022-09-02 00:31:46

by Luiz Augusto von Dentz

Subject: [PATCH] Bluetooth: hci_sync: Fix hci_read_buffer_size_sync

From: Luiz Augusto von Dentz <[email protected]>

hci_read_buffer_size_sync shall not use HCI_OP_LE_READ_BUFFER_SIZE_V2
sinze that is LE specific, instead it is hci_le_read_buffer_size_sync
version that shall use it.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216382
Fixes: 26afbd826ee3 ("Bluetooth: Add initial implementation of CIS connections")
Signed-off-by: Luiz Augusto von Dentz <[email protected]>
---
net/bluetooth/hci_sync.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index fa433896ddc7..41b6d19c70b0 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -3339,12 +3339,6 @@ static const struct hci_init_stage amp_init2[] = {
/* Read Buffer Size (ACL mtu, max pkt, etc.) */
static int hci_read_buffer_size_sync(struct hci_dev *hdev)
{
- /* Use Read LE Buffer Size V2 if supported */
- if (hdev->commands[41] & 0x20)
- return __hci_cmd_sync_status(hdev,
- HCI_OP_LE_READ_BUFFER_SIZE_V2,
- 0, NULL, HCI_CMD_TIMEOUT);
-
return __hci_cmd_sync_status(hdev, HCI_OP_READ_BUFFER_SIZE,
0, NULL, HCI_CMD_TIMEOUT);
}
@@ -3558,6 +3552,12 @@ static const struct hci_init_stage hci_init2[] = {
/* Read LE Buffer Size */
static int hci_le_read_buffer_size_sync(struct hci_dev *hdev)
{
+ /* Use Read LE Buffer Size V2 if supported */
+ if (hdev->commands[41] & 0x20)
+ return __hci_cmd_sync_status(hdev,
+ HCI_OP_LE_READ_BUFFER_SIZE_V2,
+ 0, NULL, HCI_CMD_TIMEOUT);
+
return __hci_cmd_sync_status(hdev, HCI_OP_LE_READ_BUFFER_SIZE,
0, NULL, HCI_CMD_TIMEOUT);
}
--
2.37.2

2022-09-02 03:51:54

by bluez.test.bot

Subject: RE: Bluetooth: hci_sync: Fix hci_read_buffer_size_sync

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=673423

---Test result---

Test Summary:
CheckPatch PASS 1.35 seconds
GitLint PASS 0.75 seconds
SubjectPrefix PASS 0.60 seconds
BuildKernel PASS 46.55 seconds
BuildKernel32 PASS 41.29 seconds
Incremental Build with patchesPASS 59.54 seconds
TestRunner: Setup PASS 679.00 seconds
TestRunner: l2cap-tester PASS 21.10 seconds
TestRunner: iso-tester PASS 21.79 seconds
TestRunner: bnep-tester PASS 8.44 seconds
TestRunner: mgmt-tester PASS 131.39 seconds
TestRunner: rfcomm-tester PASS 12.32 seconds
TestRunner: sco-tester PASS 12.28 seconds
TestRunner: smp-tester PASS 12.15 seconds
TestRunner: userchan-tester PASS 8.71 seconds



---
Regards,
Linux Bluetooth

2022-09-02 18:31:51

by patchwork-bot+bluetooth

Subject: Re: [PATCH] Bluetooth: hci_sync: Fix hci_read_buffer_size_sync

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 1 Sep 2022 17:27:17 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> hci_read_buffer_size_sync shall not use HCI_OP_LE_READ_BUFFER_SIZE_V2
> sinze that is LE specific, instead it is hci_le_read_buffer_size_sync
> version that shall use it.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216382
> Fixes: 26afbd826ee3 ("Bluetooth: Add initial implementation of CIS connections")
> Signed-off-by: Luiz Augusto von Dentz <[email protected]>
>
> [...]

Here is the summary with links:
- Bluetooth: hci_sync: Fix hci_read_buffer_size_sync
https://git.kernel.org/bluetooth/bluetooth-next/c/b1c013419bde

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html