2022-09-07 21:08:17

by Gix, Brian

[permalink] [raw]
Subject: [PATCH BlueZ v2 1/2] monitor: Add ADV Monitor events to btmon parser

Add missing ADV Monitor MGMT events
---
monitor/packet.c | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)

diff --git a/monitor/packet.c b/monitor/packet.c
index 46587e087..4c4f53dee 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -14914,6 +14914,37 @@ static void mgmt_controller_resume_evt(const void *data, uint16_t size)
mgmt_print_address(data, addr_type);
}

+static void mgmt_adv_monitor_device_found_evt(const void *data, uint16_t size)
+{
+ uint8_t handle = get_le16(data);
+ const uint8_t *addr = data + 2;
+ uint8_t addr_type = get_u8(data + 8);
+ int8_t rssi = get_s8(data + 9);
+ uint32_t flags = get_le32(data + 10);
+ uint16_t ad_data_len = get_le16(data + 14);
+ const uint8_t *ad_data = data + 16;
+
+ print_field("Handle: %d", handle);
+ print_bdaddr(addr);
+ print_field("Addr Type: %d", addr_type);
+ print_field("RSSI: %d", rssi);
+ mgmt_print_device_flags(flags);
+ print_field("AD Data Len: %d", ad_data_len);
+ size -= 16;
+ print_hex_field("AD Data: ", ad_data, size);
+}
+
+static void mgmt_adv_monitor_device_lost_evt(const void *data, uint16_t size)
+{
+ uint8_t handle = get_le16(data);
+ const uint8_t *addr = data + 2;
+ uint8_t addr_type = get_u8(data + 8);
+
+ print_field("Handle: %d", handle);
+ print_bdaddr(addr);
+ print_field("Addr Type: %d", addr_type);
+}
+
static const struct mgmt_data mgmt_event_table[] = {
{ 0x0001, "Command Complete",
mgmt_command_complete_evt, 3, false },
@@ -15003,6 +15034,10 @@ static const struct mgmt_data mgmt_event_table[] = {
mgmt_controller_suspend_evt, 1, true },
{ 0x002e, "Controller Resumed",
mgmt_controller_resume_evt, 8, true },
+ { 0x002f, "ADV Monitor Device Found",
+ mgmt_adv_monitor_device_found_evt, 16, false },
+ { 0x0030, "ADV Monitor Device Lost",
+ mgmt_adv_monitor_device_lost_evt, 9, true },
{ }
};

--
2.37.2


2022-09-07 22:29:09

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ,v2,1/2] monitor: Add ADV Monitor events to btmon parser

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=674993

---Test result---

Test Summary:
CheckPatch FAIL 3.41 seconds
GitLint FAIL 2.03 seconds
Prep - Setup ELL PASS 34.30 seconds
Build - Prep PASS 1.09 seconds
Build - Configure PASS 10.75 seconds
Build - Make PASS 1120.88 seconds
Make Check PASS 12.83 seconds
Make Check w/Valgrind PASS 349.08 seconds
Make Distcheck PASS 304.88 seconds
Build w/ext ELL - Configure PASS 10.82 seconds
Build w/ext ELL - Make PASS 107.26 seconds
Incremental Build w/ patches PASS 256.04 seconds
Scan Build PASS 707.92 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,v2,2/2] monitor: Add mesh MGMT cmds/events to btmon parser
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#68:
@ MGMT Command: Read Mesh Features (0x0058) plen 0 {0x0002} [hci0] 6.849795

/github/workspace/src/12969379.patch total: 0 errors, 1 warnings, 135 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12969379.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
[BlueZ,v2,2/2] monitor: Add mesh MGMT cmds/events to btmon parser
4: B1 Line exceeds max length (112>80): "@ MGMT Command: Read Mesh Features (0x0058) plen 0 {0x0002} [hci0] 6.849795"
5: B1 Line exceeds max length (112>80): "@ MGMT Event: Command Complete (0x0001) plen 7 {0x0002} [hci0] 6.849800"
12: B1 Line exceeds max length (112>80): "@ MGMT Command: Set Mesh Receiver (0x0057) plen 9 {0x0002} [hci0] 6.871462"
20: B1 Line exceeds max length (112>80): "@ MGMT Event: Command Complete (0x0001) plen 3 {0x0002} [hci0] 6.871505"
24: B1 Line exceeds max length (112>80): "@ MGMT Command: Mesh Send (0x0059) plen 43 {0x0002} [hci0] 11.865613"
32: B1 Line exceeds max length (112>80): "@ MGMT Event: Command Complete (0x0001) plen 4 {0x0002} [hci0] 11.865626"
37: B1 Line exceeds max length (112>80): "@ MGMT Event: Mesh Packet Complete (0x0032) plen 1 {0x0001} [hci0] 11.911088"




---
Regards,
Linux Bluetooth