2022-09-13 23:42:42

by Zhengping Jiang

[permalink] [raw]
Subject: [kernel PATCH v2 0/1] Bluetooth: hci_sync: allow advertise when scan without RPA


This patch allows the device to keep advertising during active scan when
ll privacy is enabled, if the device is not using privacy mode.

Changes in v2:
- Modify title to reduce length within limit

Changes in v1:
- Check privacy flag when disable advertising

Zhengping Jiang (1):
Bluetooth: hci_sync: allow advertise when scan without RPA

net/bluetooth/hci_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
2.37.2.789.g6183377224-goog


2022-09-13 23:42:46

by Zhengping Jiang

[permalink] [raw]
Subject: [kernel PATCH v2 1/1] Bluetooth: hci_sync: allow advertise when scan without RPA

Address resolution will be paused during active scan to allow any
advertising reports reach the host. If LL privacy is enabled,
advertising will rely on the controller to generate new RPA.

If host is not using RPA, there is no need to stop advertising during
active scan because there is no need to generate RPA in the controller.

Signed-off-by: Zhengping Jiang <[email protected]>
---

Changes in v2:
- Modify title to reduce length within limit

Changes in v1:
- Check privacy flag when disable advertising

net/bluetooth/hci_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 41b6d19c70b06..422f7c6911d9f 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -5351,7 +5351,7 @@ static int hci_active_scan_sync(struct hci_dev *hdev, uint16_t interval)
/* Pause advertising since active scanning disables address resolution
* which advertising depend on in order to generate its RPAs.
*/
- if (use_ll_privacy(hdev)) {
+ if (use_ll_privacy(hdev) && hci_dev_test_flag(hdev, HCI_PRIVACY)) {
err = hci_pause_advertising_sync(hdev);
if (err) {
bt_dev_err(hdev, "pause advertising failed: %d", err);
--
2.37.2.789.g6183377224-goog

2022-09-14 00:13:18

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: hci_sync: allow advertise when scan without RPA

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=676717

---Test result---

Test Summary:
CheckPatch PASS 0.85 seconds
GitLint PASS 0.46 seconds
SubjectPrefix PASS 0.31 seconds
BuildKernel PASS 41.10 seconds
BuildKernel32 PASS 35.42 seconds
Incremental Build with patchesPASS 53.59 seconds
TestRunner: Setup PASS 595.31 seconds
TestRunner: l2cap-tester PASS 19.10 seconds
TestRunner: iso-tester PASS 18.90 seconds
TestRunner: bnep-tester PASS 7.27 seconds
TestRunner: mgmt-tester PASS 117.60 seconds
TestRunner: rfcomm-tester PASS 11.28 seconds
TestRunner: sco-tester PASS 10.98 seconds
TestRunner: smp-tester PASS 10.82 seconds
TestRunner: userchan-tester PASS 7.66 seconds



---
Regards,
Linux Bluetooth