2022-09-29 10:27:20

by Christian Eggers

[permalink] [raw]
Subject: [PATCH RESEND BlueZ] client/gatt: gatt_register_app: fix parsing of UUIDs

- argv[0] (shell command) must not be used as UUID argument
- fixed linked list iteration
---
client/gatt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/client/gatt.c b/client/gatt.c
index 8f2920269118..13ff36193524 100644
--- a/client/gatt.c
+++ b/client/gatt.c
@@ -1212,7 +1212,7 @@ static gboolean get_uuids(const GDBusPropertyTable *property,
dbus_message_iter_open_container(iter, DBUS_TYPE_ARRAY,
DBUS_TYPE_STRING_AS_STRING, &entry);

- for (uuid = uuids; uuid; uuid = g_list_next(uuid->next))
+ for (uuid = uuids; uuid; uuid = g_list_next(uuid))
dbus_message_iter_append_basic(&entry, DBUS_TYPE_STRING,
&uuid->data);

@@ -1238,7 +1238,7 @@ void gatt_register_app(DBusConnection *conn, GDBusProxy *proxy,
return bt_shell_noninteractive_quit(EXIT_FAILURE);
}

- for (i = 0; i < argc; i++)
+ for (i = 1; i < argc; i++)
uuids = g_list_append(uuids, g_strdup(argv[i]));

if (uuids) {
--
2.35.3


2022-09-29 11:27:16

by bluez.test.bot

[permalink] [raw]
Subject: RE: [RESEND,BlueZ] client/gatt: gatt_register_app: fix parsing of UUIDs

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=681861

---Test result---

Test Summary:
CheckPatch PASS 1.21 seconds
GitLint PASS 0.85 seconds
Prep - Setup ELL PASS 36.44 seconds
Build - Prep PASS 0.97 seconds
Build - Configure PASS 11.33 seconds
Build - Make PASS 1236.83 seconds
Make Check PASS 13.42 seconds
Make Check w/Valgrind PASS 372.48 seconds
Make Distcheck PASS 314.48 seconds
Build w/ext ELL - Configure PASS 10.68 seconds
Build w/ext ELL - Make PASS 105.23 seconds
Incremental Build w/ patches PASS 0.00 seconds
Scan Build PASS 665.67 seconds



---
Regards,
Linux Bluetooth