2022-10-29 20:48:12

by Kang Minchul

[permalink] [raw]
Subject: [PATCH] net: bluetooth: Use kzalloc instead of kmalloc/memset

This commit replace kmalloc + memset to kzalloc
for better code readability and simplicity.

Following messages are related cocci warnings.

WARNING: kzalloc should be used for d, instead of kmalloc/memset

Signed-off-by: Kang Minchul <[email protected]>
---
net/bluetooth/hci_conn.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 7a59c4487050..287d313aa312 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -824,11 +824,10 @@ static int hci_le_terminate_big(struct hci_dev *hdev, u8 big, u8 bis)

bt_dev_dbg(hdev, "big 0x%2.2x bis 0x%2.2x", big, bis);

- d = kmalloc(sizeof(*d), GFP_KERNEL);
+ d = kzalloc(sizeof(*d), GFP_KERNEL);
if (!d)
return -ENOMEM;

- memset(d, 0, sizeof(*d));
d->big = big;
d->bis = bis;

@@ -861,11 +860,10 @@ static int hci_le_big_terminate(struct hci_dev *hdev, u8 big, u16 sync_handle)

bt_dev_dbg(hdev, "big 0x%2.2x sync_handle 0x%4.4x", big, sync_handle);

- d = kmalloc(sizeof(*d), GFP_KERNEL);
+ d = kzalloc(sizeof(*d), GFP_KERNEL);
if (!d)
return -ENOMEM;

- memset(d, 0, sizeof(*d));
d->big = big;
d->sync_handle = sync_handle;

--
2.34.1



2022-10-29 21:13:55

by bluez.test.bot

[permalink] [raw]
Subject: RE: net: bluetooth: Use kzalloc instead of kmalloc/memset

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690180

---Test result---

Test Summary:
CheckPatch PASS 1.31 seconds
GitLint PASS 0.78 seconds
SubjectPrefix FAIL 0.66 seconds
BuildKernel PASS 35.29 seconds
BuildKernel32 PASS 31.05 seconds
Incremental Build with patchesPASS 47.28 seconds
TestRunner: Setup PASS 519.68 seconds
TestRunner: l2cap-tester PASS 17.22 seconds
TestRunner: iso-tester PASS 16.32 seconds
TestRunner: bnep-tester PASS 6.29 seconds
TestRunner: mgmt-tester PASS 104.09 seconds
TestRunner: rfcomm-tester PASS 10.15 seconds
TestRunner: sco-tester PASS 9.51 seconds
TestRunner: ioctl-tester PASS 10.81 seconds
TestRunner: mesh-tester PASS 7.72 seconds
TestRunner: smp-tester PASS 9.45 seconds
TestRunner: userchan-tester PASS 6.49 seconds

Details
##############################
Test: SubjectPrefix - FAIL - 0.66 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject



---
Regards,
Linux Bluetooth

2022-10-31 23:11:47

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH] net: bluetooth: Use kzalloc instead of kmalloc/memset

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Sun, 30 Oct 2022 05:45:41 +0900 you wrote:
> This commit replace kmalloc + memset to kzalloc
> for better code readability and simplicity.
>
> Following messages are related cocci warnings.
>
> WARNING: kzalloc should be used for d, instead of kmalloc/memset
>
> [...]

Here is the summary with links:
- net: bluetooth: Use kzalloc instead of kmalloc/memset
https://git.kernel.org/bluetooth/bluetooth-next/c/214c507d87cc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html