2022-11-09 09:46:59

by Wangshaobo (bobo)

[permalink] [raw]
Subject: [PATCH] Bluetooth: 6LoWPAN: add missing hci_dev_put() in get_l2cap_conn()

hci_get_route() takes reference, we should use hci_dev_put() to release
it when not need anymore.

Fixes: 6b8d4a6a0314 ("Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one")
Signed-off-by: Wang ShaoBo <[email protected]>
---
net/bluetooth/6lowpan.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 215af9b3b589..c57d643afb10 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -972,6 +972,7 @@ static int get_l2cap_conn(char *buf, bdaddr_t *addr, u8 *addr_type,
hci_dev_lock(hdev);
hcon = hci_conn_hash_lookup_le(hdev, addr, *addr_type);
hci_dev_unlock(hdev);
+ hci_dev_put(hdev);

if (!hcon)
return -ENOENT;
--
2.25.1



2022-11-09 10:18:09

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: 6LoWPAN: add missing hci_dev_put() in get_l2cap_conn()

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=693552

---Test result---

Test Summary:
CheckPatch PASS 1.69 seconds
GitLint PASS 0.93 seconds
SubjectPrefix PASS 0.87 seconds
BuildKernel PASS 33.96 seconds
BuildKernel32 PASS 30.86 seconds
Incremental Build with patchesPASS 45.61 seconds
TestRunner: Setup PASS 509.62 seconds
TestRunner: l2cap-tester PASS 17.54 seconds
TestRunner: iso-tester PASS 16.42 seconds
TestRunner: bnep-tester PASS 6.55 seconds
TestRunner: mgmt-tester PASS 107.40 seconds
TestRunner: rfcomm-tester PASS 10.47 seconds
TestRunner: sco-tester PASS 9.83 seconds
TestRunner: ioctl-tester PASS 11.17 seconds
TestRunner: mesh-tester PASS 8.13 seconds
TestRunner: smp-tester PASS 9.90 seconds
TestRunner: userchan-tester PASS 6.85 seconds



---
Regards,
Linux Bluetooth

2022-11-14 22:18:53

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: 6LoWPAN: add missing hci_dev_put() in get_l2cap_conn()

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 9 Nov 2022 17:37:26 +0800 you wrote:
> hci_get_route() takes reference, we should use hci_dev_put() to release
> it when not need anymore.
>
> Fixes: 6b8d4a6a0314 ("Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one")
> Signed-off-by: Wang ShaoBo <[email protected]>
> ---
> net/bluetooth/6lowpan.c | 1 +
> 1 file changed, 1 insertion(+)

Here is the summary with links:
- Bluetooth: 6LoWPAN: add missing hci_dev_put() in get_l2cap_conn()
https://git.kernel.org/bluetooth/bluetooth-next/c/190ea3c3a8d5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html