2022-11-21 23:47:45

by Sathish Narasimman

[permalink] [raw]
Subject: [PATCH BlueZ 1/6] lib/uuid: Add CSIS UUIDs

This adds Coordinated Set Identification Service UUIDs which will
be used by Coordinated Set Identification Profile.
---
lib/uuid.h | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/lib/uuid.h b/lib/uuid.h
index d5e5665e475c..84ff46cd8f36 100644
--- a/lib/uuid.h
+++ b/lib/uuid.h
@@ -186,6 +186,13 @@ extern "C" {
#define MEDIA_CP_OP_SUPPORTED_CHRC_UUID 0x2ba5
#define MEDIA_CONTENT_CONTROL_ID_CHRC_UUID 0x2bba

+/* Coordinated Set Identification Profile(CSIP) */
+#define CSIS_UUID 0x1846
+#define CS_SIRK 0x2B84
+#define CS_SIZE 0x2B85
+#define CS_LOCK 0x2B86
+#define CS_RANK 0x2B87
+
typedef struct {
enum {
BT_UUID_UNSPEC = 0,
--
2.25.1



2022-11-22 03:10:51

by bluez.test.bot

[permalink] [raw]
Subject: RE: CSIP - Client Role

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=697847

---Test result---

Test Summary:
CheckPatch FAIL 3.33 seconds
GitLint PASS 1.63 seconds
BuildEll PASS 26.59 seconds
BluezMake PASS 760.57 seconds
MakeCheck PASS 10.81 seconds
MakeDistcheck PASS 146.48 seconds
CheckValgrind PASS 239.47 seconds
bluezmakeextell PASS 94.21 seconds
IncrementalBuild PASS 3722.53 seconds
ScanBuild WARNING 997.30 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,2/6] main.conf: Add CSIP profile configurable options
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#119: FILE: src/main.c:151:
+static const char *csip_options[] = {

/github/workspace/src/src/13051723.patch total: 0 errors, 1 warnings, 199 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13051723.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


[BlueZ,3/6] shared/csip: Add initial code for handling CSIP
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#668: FILE: src/shared/csip.h:16:
+#define __packed __attribute__((packed))

/github/workspace/src/src/13051726.patch total: 0 errors, 1 warnings, 605 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13051726.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


[BlueZ,4/6] profiles: Add initial code for csip plugin
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#404: FILE: profiles/audio/csip.c:295:
+static unsigned int csip_id = 0;

/github/workspace/src/src/13051729.patch total: 1 errors, 0 warnings, 337 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13051729.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
src/main.c:209:2: warning: Undefined or garbage value returned to caller
return val;
^~~~~~~~~~
1 warning generated.
tools/advtest.c:106:9: warning: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage
rsi[5] &= 0x3f; /* Clear 2 msb */
~~~~~~ ^
1 warning generated.



---
Regards,
Linux Bluetooth