2023-01-30 09:14:34

by Marcin Kraglak

Subject: [PATCH] monitor/att: Fix Set Member Lock decoding

According to CSIS specification v1.0.1: "Allowed values for the Set
Member Lock characteristic are Unlocked (corresponding to the
numeric value 0x01) and Locked (corresponding to the numeric
value 0x02); all other values are RFU".
---
monitor/att.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/monitor/att.c b/monitor/att.c
index 3b78884bc..05784e9f4 100644
--- a/monitor/att.c
+++ b/monitor/att.c
@@ -1760,10 +1760,10 @@ static void csip_lock_read(const struct l2cap_frame *frame)

switch (lock) {
case 0x01:
- print_field(" Locked (0x%02x)", lock);
+ print_field(" Unlocked (0x%02x)", lock);
break;
case 0x02:
- print_field(" Unlocked (0x%02x)", lock);
+ print_field(" Locked (0x%02x)", lock);
break;
default:
print_field(" RFU (0x%02x)", lock);
--
2.39.1

2023-01-30 10:55:39

by bluez.test.bot

Subject: RE: monitor/att: Fix Set Member Lock decoding

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=716824

---Test result---

Test Summary:
CheckPatch PASS 0.75 seconds
GitLint PASS 0.30 seconds
BuildEll PASS 35.55 seconds
BluezMake PASS 1167.50 seconds
MakeCheck PASS 13.44 seconds
MakeDistcheck PASS 191.67 seconds
CheckValgrind PASS 314.94 seconds
CheckSmatch WARNING 434.30 seconds
bluezmakeextell PASS 127.17 seconds
IncrementalBuild PASS 970.60 seconds
ScanBuild PASS 1386.96 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/att.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.


---
Regards,
Linux Bluetooth

2023-01-30 21:40:34

by patchwork-bot+bluetooth

Subject: Re: [PATCH] monitor/att: Fix Set Member Lock decoding

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Mon, 30 Jan 2023 10:13:36 +0100 you wrote:
> According to CSIS specification v1.0.1: "Allowed values for the Set
> Member Lock characteristic are Unlocked (corresponding to the
> numeric value 0x01) and Locked (corresponding to the numeric
> value 0x02); all other values are RFU".
> ---
> monitor/att.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- monitor/att: Fix Set Member Lock decoding
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f367fa3c9fe5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html