From: Tedd Ho-Jeong An <[email protected]>
If the 'enable-external-ell' is not specified in the configure parameter,
the build system assumes that the ELL source is located same level where
the bluez source is cloned. But the configure doens't check the folder
and user will get the build error while building the source.
This patch checks if the ELL source path if the 'enable-external-ell'
flag is not set and throws an error if the ELL doesn't exist.
---
configure.ac | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/configure.ac b/configure.ac
index f9f0faf57..6e76133c2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -289,6 +289,10 @@ if (test "${enable_external_ell}" = "yes"); then
AC_SUBST(ELL_CFLAGS)
AC_SUBST(ELL_LIBS)
fi
+if (test "${enable_external_ell}" != "yes"); then
+ AC_CHECK_FILE(../ell, dummy=yes,
+ AC_MSG_ERROR(ELL source is required at ../ell))
+fi
AM_CONDITIONAL(EXTERNAL_ELL, test "${enable_external_ell}" = "yes" ||
(test "${enable_btpclient}" != "yes" &&
test "${enable_mesh}" != "yes"))
--
2.39.2
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=723140
---Test result---
Test Summary:
CheckPatch PASS 0.36 seconds
GitLint PASS 0.22 seconds
BuildEll PASS 32.23 seconds
BluezMake PASS 1068.41 seconds
MakeCheck PASS 12.67 seconds
MakeDistcheck FAIL 30.47 seconds
CheckValgrind PASS 292.83 seconds
CheckSmatch PASS 400.75 seconds
bluezmakeextell PASS 118.62 seconds
IncrementalBuild PASS 897.90 seconds
ScanBuild PASS 1283.01 seconds
Details
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:
configure: error: ELL source is required at ../ell
make: *** [Makefile:11618: distcheck] Error 1
---
Regards,
Linux Bluetooth