From: Chris Morgan <[email protected]>
This patch series is to add support for the RTL8821CS Bluetooth
controller found on the RTL8821CS WiFi/Bluetooth combo chip.
This has been tested with firmware version 0x75b8f098 which has been
submitted by Realtek for inclusion in linux-firmware.
https://lore.kernel.org/linux-firmware/[email protected]/
Changes from V2:
- Corrected devicetree documentation to change compatible from const
back to enum.
- Removed "reviewed-by" from Alistair Francis as binding documentation
updated with changes.
Changes from V1:
- Switched to use a fallback string for the rtl8822cs so as to not add
an extra entry to the of_device_id table. The driver is capable of
selecting the correct firmware blob to load.
- Updated the messages to note a new version of the firmware was
tested and that Realtek has submitted this firmware upstream.
- Updated the devicetree node on the Anbernic RGxx3 series to use the
fallback string of realtek,rtl8822cs-bt.
Chris Morgan (3):
dt-bindings: net: realtek-bluetooth: Add RTL8821CS
Bluetooth: hci_h5: btrtl: Add support for RTL8821CS
arm64: dts: rockchip: Update compatible for bluetooth
.../bindings/net/realtek-bluetooth.yaml | 25 ++++++++++++-------
.../dts/rockchip/rk3566-anbernic-rgxx3.dtsi | 2 +-
drivers/bluetooth/btrtl.c | 8 ++++++
3 files changed, 25 insertions(+), 10 deletions(-)
--
2.34.1
From: Chris Morgan <[email protected]>
Update the compatible for the Realtek RTL8821CS bluetooth node.
Signed-off-by: Chris Morgan <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
index 41262a69d33e..8fadd8afb190 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
@@ -716,7 +716,7 @@ &uart1 {
status = "okay";
bluetooth {
- compatible = "realtek,rtl8821cs-bt";
+ compatible = "realtek,rtl8821cs-bt", "realtek,rtl8822cs-bt";
device-wake-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
enable-gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>;
host-wake-gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>;
--
2.34.1
From: Chris Morgan <[email protected]>
Add compatible string for RTL8821CS for existing Realtek Bluetooth
driver.
Signed-off-by: Chris Morgan <[email protected]>
---
.../bindings/net/realtek-bluetooth.yaml | 25 ++++++++++++-------
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
index 143b5667abad..198c5dd1f257 100644
--- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
@@ -4,24 +4,31 @@
$id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: RTL8723BS/RTL8723CS/RTL8822CS Bluetooth
+title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth
maintainers:
- Vasily Khoruzhick <[email protected]>
- Alistair Francis <[email protected]>
description:
- RTL8723CS/RTL8723CS/RTL8822CS is WiFi + BT chip. WiFi part is connected over
- SDIO, while BT is connected over serial. It speaks H5 protocol with few
- extra commands to upload firmware and change module speed.
+ RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part
+ is connected over SDIO, while BT is connected over serial. It speaks
+ H5 protocol with few extra commands to upload firmware and change
+ module speed.
properties:
compatible:
- enum:
- - realtek,rtl8723bs-bt
- - realtek,rtl8723cs-bt
- - realtek,rtl8723ds-bt
- - realtek,rtl8822cs-bt
+ oneOf:
+ - items:
+ - enum:
+ - realtek,rtl8723bs-bt
+ - realtek,rtl8723cs-bt
+ - realtek,rtl8723ds-bt
+ - realtek,rtl8822cs-bt
+ - items:
+ - enum:
+ - realtek,rtl8821cs-bt
+ - const: realtek,rtl8822cs-bt
device-wake-gpios:
maxItems: 1
--
2.34.1
On 27/02/2023 17:30, Chris Morgan wrote:
> From: Chris Morgan <[email protected]>
>
> Add compatible string for RTL8821CS for existing Realtek Bluetooth
> driver.
>
> Signed-off-by: Chris Morgan <[email protected]>
> ---
> .../bindings/net/realtek-bluetooth.yaml | 25 ++++++++++++-------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> index 143b5667abad..198c5dd1f257 100644
> --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> @@ -4,24 +4,31 @@
> $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: RTL8723BS/RTL8723CS/RTL8822CS Bluetooth
> +title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth
>
> maintainers:
> - Vasily Khoruzhick <[email protected]>
> - Alistair Francis <[email protected]>
>
> description:
> - RTL8723CS/RTL8723CS/RTL8822CS is WiFi + BT chip. WiFi part is connected over
> - SDIO, while BT is connected over serial. It speaks H5 protocol with few
> - extra commands to upload firmware and change module speed.
> + RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part
> + is connected over SDIO, while BT is connected over serial. It speaks
> + H5 protocol with few extra commands to upload firmware and change
> + module speed.
>
> properties:
> compatible:
> - enum:
> - - realtek,rtl8723bs-bt
> - - realtek,rtl8723cs-bt
> - - realtek,rtl8723ds-bt
> - - realtek,rtl8822cs-bt
> + oneOf:
> + - items:
Now you added items which were never here... You have only one item, so
no need for items.
Best regards,
Krzysztof
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=725242
---Test result---
Test Summary:
CheckPatch PASS 1.66 seconds
GitLint PASS 0.80 seconds
SubjectPrefix FAIL 0.58 seconds
BuildKernel PASS 30.67 seconds
CheckAllWarning PASS 34.03 seconds
CheckSparse WARNING 38.86 seconds
CheckSmatch WARNING 108.94 seconds
BuildKernel32 PASS 30.08 seconds
TestRunnerSetup PASS 432.95 seconds
TestRunner_l2cap-tester PASS 15.83 seconds
TestRunner_iso-tester PASS 16.38 seconds
TestRunner_bnep-tester PASS 5.28 seconds
TestRunner_mgmt-tester PASS 107.75 seconds
TestRunner_rfcomm-tester PASS 8.54 seconds
TestRunner_sco-tester PASS 7.86 seconds
TestRunner_ioctl-tester PASS 9.07 seconds
TestRunner_mesh-tester PASS 6.69 seconds
TestRunner_smp-tester PASS 7.73 seconds
TestRunner_userchan-tester PASS 5.60 seconds
IncrementalBuild PASS 36.06 seconds
Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible structures
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible structures
---
Regards,
Linux Bluetooth