2023-04-03 20:39:58

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ] set: Fix not attempt to connect devices with RSI

From: Luiz Augusto von Dentz <[email protected]>

If a device advertising with RSI is only found later after the set was
already create we shall still attempt to connect to it.
---
src/set.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/set.c b/src/set.c
index f1008a057f90..ad64fb163b25 100644
--- a/src/set.c
+++ b/src/set.c
@@ -317,7 +317,8 @@ struct btd_device_set *btd_set_add_device(struct btd_device *device,
set = set_find(device, sirk);
if (set) {
set_add(set, device);
- return set;
+ /* Check if there are new devices with RSI found */
+ goto done;
}

set = set_new(device, sirk, size);
@@ -329,6 +330,7 @@ struct btd_device_set *btd_set_add_device(struct btd_device *device,

queue_push_tail(set_list, set);

+done:
/* Attempt to add devices which have matching RSI */
btd_adapter_for_each_device(device_get_adapter(device), foreach_device,
set);
--
2.39.2


2023-04-03 21:50:14

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ] set: Fix not attempt to connect devices with RSI

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=736551

---Test result---

Test Summary:
CheckPatch PASS 0.45 seconds
GitLint PASS 0.31 seconds
BuildEll PASS 32.36 seconds
BluezMake PASS 1010.84 seconds
MakeCheck PASS 12.63 seconds
MakeDistcheck PASS 180.25 seconds
CheckValgrind PASS 297.27 seconds
CheckSmatch PASS 400.86 seconds
bluezmakeextell PASS 119.21 seconds
IncrementalBuild PASS 831.70 seconds
ScanBuild PASS 1249.51 seconds



---
Regards,
Linux Bluetooth

2023-04-05 19:52:40

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH BlueZ] set: Fix not attempt to connect devices with RSI

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Mon, 3 Apr 2023 13:32:43 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> If a device advertising with RSI is only found later after the set was
> already create we shall still attempt to connect to it.
> ---
> src/set.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Here is the summary with links:
- [BlueZ] set: Fix not attempt to connect devices with RSI
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7aee0b67ba9f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html