2023-05-10 13:48:02

by Claudia Draghicescu

[permalink] [raw]
Subject: [PATCH v2 0/1] Bluetooth: Check for ISO support in controller

This patch checks for ISO_BROADCASTER and ISO_SYNC_RECEIVER in controller.

Claudia Draghicescu (1):
Check for ISO_BROADCASTER and ISO_SYNC_RECEIVER bits in adapter's
supported features

include/net/bluetooth/hci.h | 1 +
include/net/bluetooth/hci_core.h | 1 +
include/net/bluetooth/mgmt.h | 2 ++
net/bluetooth/mgmt.c | 6 ++++++
4 files changed, 10 insertions(+)

--
2.34.1



2023-05-10 13:48:14

by Claudia Draghicescu

[permalink] [raw]
Subject: [PATCH v2 1/1] Bluetooth: Check for ISO support in controller

This patch checks for ISO_BROADCASTER and ISO_SYNC_RECEIVER in controller.
Signed-off-by: Claudia Draghicescu <[email protected]>
---
include/net/bluetooth/hci.h | 1 +
include/net/bluetooth/hci_core.h | 1 +
include/net/bluetooth/mgmt.h | 2 ++
net/bluetooth/mgmt.c | 6 ++++++
4 files changed, 10 insertions(+)

diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 07df96c47ef4..16a452438dfd 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -576,6 +576,7 @@ enum {
#define HCI_LE_CIS_CENTRAL 0x10
#define HCI_LE_CIS_PERIPHERAL 0x20
#define HCI_LE_ISO_BROADCASTER 0x40
+#define HCI_LE_ISO_SYNC_RECEIVER 0x80

/* Connection modes */
#define HCI_CM_ACTIVE 0x0000
diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index a6c8aee2f256..6a0ffe027d57 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -1760,6 +1760,7 @@ void hci_conn_del_sysfs(struct hci_conn *conn);
#define cis_peripheral_capable(dev) \
((dev)->le_features[3] & HCI_LE_CIS_PERIPHERAL)
#define bis_capable(dev) ((dev)->le_features[3] & HCI_LE_ISO_BROADCASTER)
+#define sync_recv_capable(dev) ((dev)->le_features[3] & HCI_LE_ISO_SYNC_RECEIVER)

#define mws_transport_config_capable(dev) (((dev)->commands[30] & 0x08) && \
(!test_bit(HCI_QUIRK_BROKEN_MWS_TRANSPORT_CONFIG, &(dev)->quirks)))
diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
index a5801649f619..7eeec8501846 100644
--- a/include/net/bluetooth/mgmt.h
+++ b/include/net/bluetooth/mgmt.h
@@ -111,6 +111,8 @@ struct mgmt_rp_read_index_list {
#define MGMT_SETTING_WIDEBAND_SPEECH BIT(17)
#define MGMT_SETTING_CIS_CENTRAL BIT(18)
#define MGMT_SETTING_CIS_PERIPHERAL BIT(19)
+#define MGMT_SETTING_ISO_BROADCASTER BIT(20)
+#define MGMT_SETTING_ISO_SYNC_RECEIVER BIT(21)

#define MGMT_OP_READ_INFO 0x0004
#define MGMT_READ_INFO_SIZE 0
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index f7b2d0971f24..61c8e1b8f3b0 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -944,6 +944,12 @@ static u32 get_current_settings(struct hci_dev *hdev)
if (cis_peripheral_capable(hdev))
settings |= MGMT_SETTING_CIS_PERIPHERAL;

+ if (bis_capable(hdev))
+ settings |= MGMT_SETTING_ISO_BROADCASTER;
+
+ if (sync_recv_capable(hdev))
+ settings |= MGMT_SETTING_ISO_SYNC_RECEIVER;
+
return settings;
}

--
2.34.1


2023-05-10 14:49:22

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: Check for ISO support in controller

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=746439

---Test result---

Test Summary:
CheckPatch PASS 1.25 seconds
GitLint PASS 0.31 seconds
SubjectPrefix PASS 0.10 seconds
BuildKernel PASS 40.69 seconds
CheckAllWarning PASS 43.72 seconds
CheckSparse PASS 48.83 seconds
CheckSmatch PASS 134.15 seconds
BuildKernel32 PASS 39.52 seconds
TestRunnerSetup PASS 558.98 seconds
TestRunner_l2cap-tester PASS 20.03 seconds
TestRunner_iso-tester PASS 26.12 seconds
TestRunner_bnep-tester PASS 6.72 seconds
TestRunner_mgmt-tester PASS 137.39 seconds
TestRunner_rfcomm-tester PASS 10.83 seconds
TestRunner_sco-tester PASS 9.68 seconds
TestRunner_ioctl-tester PASS 11.62 seconds
TestRunner_mesh-tester PASS 8.66 seconds
TestRunner_smp-tester PASS 9.78 seconds
TestRunner_userchan-tester PASS 7.50 seconds
IncrementalBuild PASS 37.18 seconds



---
Regards,
Linux Bluetooth

2023-05-15 19:56:51

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH v2 0/1] Bluetooth: Check for ISO support in controller

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 10 May 2023 16:45:56 +0300 you wrote:
> This patch checks for ISO_BROADCASTER and ISO_SYNC_RECEIVER in controller.
>
> Claudia Draghicescu (1):
> Check for ISO_BROADCASTER and ISO_SYNC_RECEIVER bits in adapter's
> supported features
>
> include/net/bluetooth/hci.h | 1 +
> include/net/bluetooth/hci_core.h | 1 +
> include/net/bluetooth/mgmt.h | 2 ++
> net/bluetooth/mgmt.c | 6 ++++++
> 4 files changed, 10 insertions(+)

Here is the summary with links:
- [v2,1/1] Bluetooth: Check for ISO support in controller
https://git.kernel.org/bluetooth/bluetooth-next/c/fd4fbf8cd81f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



2023-05-16 02:36:43

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [PATCH v2 0/1] Bluetooth: Check for ISO support in controller

Hi Claudia,

On Mon, May 15, 2023 at 12:56 PM <[email protected]> wrote:
>
> Hello:
>
> This patch was applied to bluetooth/bluetooth-next.git (master)
> by Luiz Augusto von Dentz <[email protected]>:
>
> On Wed, 10 May 2023 16:45:56 +0300 you wrote:
> > This patch checks for ISO_BROADCASTER and ISO_SYNC_RECEIVER in controller.
> >
> > Claudia Draghicescu (1):
> > Check for ISO_BROADCASTER and ISO_SYNC_RECEIVER bits in adapter's
> > supported features
> >
> > include/net/bluetooth/hci.h | 1 +
> > include/net/bluetooth/hci_core.h | 1 +
> > include/net/bluetooth/mgmt.h | 2 ++
> > net/bluetooth/mgmt.c | 6 ++++++
> > 4 files changed, 10 insertions(+)
>
> Here is the summary with links:
> - [v2,1/1] Bluetooth: Check for ISO support in controller
> https://git.kernel.org/bluetooth/bluetooth-next/c/fd4fbf8cd81f
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html

Btw, we need to update the documentation:

https://github.com/bluez/bluez/blob/master/doc/mgmt-api.txt#L336

And decoding support:

https://github.com/bluez/bluez/blob/master/monitor/packet.c#L12656

>


--
Luiz Augusto von Dentz