2023-05-11 00:40:07

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ 1/2] client/player: Fix crashes accessing metadata

From: Luiz Augusto von Dentz <[email protected]>

If metadata is not set the respective iovec is left NULL so it needs to
be checked before accessing its fields.
---
client/player.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/client/player.c b/client/player.c
index f055ff941569..091d7005f42a 100644
--- a/client/player.c
+++ b/client/player.c
@@ -1743,7 +1743,7 @@ static void append_properties(DBusMessageIter *iter,
DBUS_TYPE_BYTE, &cfg->caps->iov_base,
cfg->caps->iov_len);

- if (cfg->meta->iov_len) {
+ if (cfg->meta && cfg->meta->iov_len) {
g_dbus_dict_append_basic_array(&dict, DBUS_TYPE_STRING, &meta,
DBUS_TYPE_BYTE, &cfg->meta->iov_base,
cfg->meta->iov_len);
@@ -1850,7 +1850,8 @@ static DBusMessage *endpoint_select_properties_reply(struct endpoint *ep,
cfg->target_latency = preset->target_latency;

/* Copy metadata */
- iov_append(&cfg->meta, cfg->ep->meta->iov_base, cfg->ep->meta->iov_len);
+ if (ep->meta)
+ iov_append(&cfg->meta, ep->meta->iov_base, ep->meta->iov_len);

if (preset->qos.phy)
/* Set QoS parameters */
--
2.40.0

2023-05-11 02:34:10

by bluez.test.bot

Subject: RE: [BlueZ,1/2] client/player: Fix crashes accessing metadata

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=746595

---Test result---

Test Summary:
CheckPatch PASS 1.05 seconds
GitLint PASS 0.71 seconds
BuildEll PASS 26.91 seconds
BluezMake PASS 1003.92 seconds
MakeCheck PASS 12.50 seconds
MakeDistcheck PASS 155.98 seconds
CheckValgrind PASS 252.51 seconds
CheckSmatch PASS 338.80 seconds
bluezmakeextell PASS 102.02 seconds
IncrementalBuild PASS 1716.07 seconds
ScanBuild PASS 1049.43 seconds



---
Regards,
Linux Bluetooth

2023-05-12 20:42:27

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ 1/2] client/player: Fix crashes accessing metadata

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 10 May 2023 17:01:54 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> If metadata is not set the respective iovec is left NULL so it needs to
> be checked before accessing its fields.
> ---
> client/player.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

Here is the summary with links:
- [BlueZ,1/2] client/player: Fix crashes accessing metadata
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=67fd8479f11c
- [BlueZ,2/2] shared/bap: Fix not sending ASE Receiver Stop Ready
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=24b4ba1a3936

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html