2023-05-18 07:38:57

by Neeraj Sanjay Kale

[permalink] [raw]
Subject: [PATCH v2] Bluetooth: btnxpuart: Fix compiler warnings

This fixes a compiler warning reported by kernel test robot.

Signed-off-by: Neeraj Sanjay Kale <[email protected]>
Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
---
drivers/bluetooth/btnxpuart.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 3a34d7c1475b..ba8093367f9a 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -1319,6 +1319,7 @@ static void nxp_serdev_remove(struct serdev_device *serdev)
hci_free_dev(hdev);
}

+#ifdef CONFIG_OF
static struct btnxpuart_data w8987_data = {
.helper_fw_name = NULL,
.fw_name = FIRMWARE_W8987,
@@ -1335,6 +1336,7 @@ static const struct of_device_id nxpuart_of_match_table[] = {
{ }
};
MODULE_DEVICE_TABLE(of, nxpuart_of_match_table);
+#endif

static struct serdev_device_driver nxp_serdev_driver = {
.probe = nxp_serdev_probe,
--
2.34.1



2023-05-18 08:42:23

by bluez.test.bot

[permalink] [raw]
Subject: RE: [v2] Bluetooth: btnxpuart: Fix compiler warnings

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=748779

---Test result---

Test Summary:
CheckPatch PASS 0.72 seconds
GitLint PASS 0.34 seconds
SubjectPrefix PASS 0.10 seconds
BuildKernel PASS 41.18 seconds
CheckAllWarning PASS 46.64 seconds
CheckSparse PASS 51.56 seconds
CheckSmatch PASS 139.75 seconds
BuildKernel32 PASS 41.00 seconds
TestRunnerSetup PASS 584.91 seconds
TestRunner_l2cap-tester PASS 20.78 seconds
TestRunner_iso-tester PASS 27.55 seconds
TestRunner_bnep-tester PASS 7.55 seconds
TestRunner_mgmt-tester PASS 143.95 seconds
TestRunner_rfcomm-tester PASS 11.24 seconds
TestRunner_sco-tester PASS 10.66 seconds
TestRunner_ioctl-tester PASS 12.65 seconds
TestRunner_mesh-tester PASS 9.53 seconds
TestRunner_smp-tester PASS 10.31 seconds
TestRunner_userchan-tester PASS 7.54 seconds
IncrementalBuild PASS 39.90 seconds



---
Regards,
Linux Bluetooth

2023-05-18 16:12:21

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [v2] Bluetooth: btnxpuart: Fix compiler warnings

Hi Neeraj,

On Thu, May 18, 2023 at 1:42 AM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=748779
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 0.72 seconds
> GitLint PASS 0.34 seconds
> SubjectPrefix PASS 0.10 seconds
> BuildKernel PASS 41.18 seconds
> CheckAllWarning PASS 46.64 seconds
> CheckSparse PASS 51.56 seconds
> CheckSmatch PASS 139.75 seconds
> BuildKernel32 PASS 41.00 seconds
> TestRunnerSetup PASS 584.91 seconds
> TestRunner_l2cap-tester PASS 20.78 seconds
> TestRunner_iso-tester PASS 27.55 seconds
> TestRunner_bnep-tester PASS 7.55 seconds
> TestRunner_mgmt-tester PASS 143.95 seconds
> TestRunner_rfcomm-tester PASS 11.24 seconds
> TestRunner_sco-tester PASS 10.66 seconds
> TestRunner_ioctl-tester PASS 12.65 seconds
> TestRunner_mesh-tester PASS 9.53 seconds
> TestRunner_smp-tester PASS 10.31 seconds
> TestRunner_userchan-tester PASS 7.54 seconds
> IncrementalBuild PASS 39.90 seconds

Perhaps we should use __maybe_unused like in the following change:

https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=0811ff480978a2122f0465cb8682d9f7a2f6a169

>
>
> ---
> Regards,
> Linux Bluetooth
>


--
Luiz Augusto von Dentz