2023-06-01 23:43:55

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ 1/2] monitor: Only print credentials if PID is set

From: Luiz Augusto von Dentz <[email protected]>

If PID is not set don't print anything since this is likely a packet
originated by the kernel itself.
---
monitor/packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 946ceb2c640d..6d73e5abfcbc 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -438,7 +438,7 @@ static void print_packet(struct timeval *tv, struct ucred *cred, char ident,
pos += n;
}

- if (cred) {
+ if (cred && cred->pid) {
cred_pid(cred, pid_str, sizeof(pid_str));
n = sprintf(line + pos, "%s: %c %s", pid_str, ident,
label ? label : "");
--
2.40.1

2023-06-02 00:59:28

by bluez.test.bot

Subject: RE: [BlueZ,1/2] monitor: Only print credentials if PID is set

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=753319

---Test result---

Test Summary:
CheckPatch PASS 1.05 seconds
GitLint PASS 0.74 seconds
BuildEll PASS 27.23 seconds
BluezMake PASS 889.25 seconds
MakeCheck PASS 12.26 seconds
MakeDistcheck PASS 155.68 seconds
CheckValgrind PASS 252.09 seconds
CheckSmatch WARNING 341.89 seconds
bluezmakeextell PASS 103.28 seconds
IncrementalBuild PASS 1456.56 seconds
ScanBuild PASS 1036.99 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3552:52: warning: array of flexible structuresmonitor/bt.h:3540:40: warning: array of flexible structures


---
Regards,
Linux Bluetooth

2023-06-02 20:00:06

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ 1/2] monitor: Only print credentials if PID is set

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 1 Jun 2023 16:33:16 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> If PID is not set don't print anything since this is likely a packet
> originated by the kernel itself.
> ---
> monitor/packet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [BlueZ,1/2] monitor: Only print credentials if PID is set
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f84979c1591f
- [BlueZ,2/2] shared/bap: Don't overwrite attribute declaration
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=52477e80fc89

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html