2023-06-20 22:54:23

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ 1/2] monitor: Fix decoding of HCI CIS Established Event

From: Luiz Augusto von Dentz <[email protected]>

The ISO Interval is actually using set using 1.25ms slots:

BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 4, Part E
page 2304:

Time = N * 1.25 ms
---
monitor/packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 4473fda29a46..cd567231449e 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -11557,7 +11557,7 @@ static void le_cis_established_evt(struct timeval *tv, uint16_t index,
print_field("Peripheral to Central Flush Timeout: %u", evt->p_ft);
print_field("Central to Peripheral MTU: %u", le16_to_cpu(evt->c_mtu));
print_field("Peripheral to Central MTU: %u", le16_to_cpu(evt->p_mtu));
- print_field("ISO Interval: %u", le16_to_cpu(evt->interval));
+ print_slot_125("ISO Interval", evt->interval);
}

static void le_req_cis_evt(struct timeval *tv, uint16_t index,
--
2.40.1

2023-06-20 22:55:20

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ 2/2] btdev: Fix CIS Establish ISO Interval

From: Luiz Augusto von Dentz <[email protected]>

ISO Interval is actually using 1.25 ms slots so it needs to be properly
converted.
---
emulator/btdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emulator/btdev.c b/emulator/btdev.c
index 462f352ea252..ad637ecb8afd 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -5977,7 +5977,7 @@ static void le_cis_estabilished(struct btdev *dev, struct btdev_conn *conn,
evt.p_ft = 0x01;
evt.c_mtu = le_cig->cis[cis_idx].c_sdu;
evt.p_mtu = le_cig->cis[cis_idx].p_sdu;
- evt.interval = le_cig->params.c_latency;
+ evt.interval = le_cig->params.c_latency / 1.25;
}

le_meta_event(dev, BT_HCI_EVT_LE_CIS_ESTABLISHED, &evt, sizeof(evt));
--
2.40.1

2023-06-21 00:37:21

by bluez.test.bot

Subject: RE: [BlueZ,1/2] monitor: Fix decoding of HCI CIS Established Event

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=758879

---Test result---

Test Summary:
CheckPatch PASS 0.73 seconds
GitLint PASS 0.52 seconds
BuildEll PASS 26.96 seconds
BluezMake PASS 786.35 seconds
MakeCheck PASS 11.94 seconds
MakeDistcheck PASS 156.16 seconds
CheckValgrind PASS 249.75 seconds
CheckSmatch WARNING 337.65 seconds
bluezmakeextell PASS 102.01 seconds
IncrementalBuild PASS 1316.00 seconds
ScanBuild PASS 1018.60 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3552:52: warning: array of flexible structuresmonitor/bt.h:3540:40: warning: array of flexible structuresemulator/btdev.c:417:29: warning: Variable length array is used.


---
Regards,
Linux Bluetooth