2023-07-21 12:06:50

by Łukasz Rymanowski

[permalink] [raw]
Subject: [PATCH BlueZ 1/4] monitor: Fix adv_handle size in the set info transfer packet

From: Jakub Tyszkowski <[email protected]>

As per Bluetooth Core 5.4 Vol 4. Part E, 7.8.90,
adv_handle is 1 octet size and not 2.
---
monitor/bt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/bt.h b/monitor/bt.h
index 37fcdaeaa..131024e46 100644
--- a/monitor/bt.h
+++ b/monitor/bt.h
@@ -2608,7 +2608,7 @@ struct bt_hci_cmd_periodic_sync_trans {
struct bt_hci_cmd_pa_set_info_trans {
uint16_t handle;
uint16_t service_data;
- uint16_t adv_handle;
+ uint8_t adv_handle;
} __attribute__ ((packed));

#define BT_HCI_CMD_PA_SYNC_TRANS_PARAMS 0x205c
--
2.34.1



2023-07-21 14:34:29

by bluez.test.bot

[permalink] [raw]
Subject: RE: Minor monitor changes around Broadcast

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=768234

---Test result---

Test Summary:
CheckPatch PASS 1.71 seconds
GitLint PASS 1.17 seconds
BuildEll PASS 33.72 seconds
BluezMake PASS 1198.26 seconds
MakeCheck PASS 13.50 seconds
MakeDistcheck PASS 201.39 seconds
CheckValgrind PASS 325.06 seconds
CheckSmatch WARNING 449.45 seconds
bluezmakeextell PASS 132.61 seconds
IncrementalBuild PASS 3938.19 seconds
ScanBuild PASS 1351.01 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3551:52: warning: array of flexible structuresmonitor/bt.h:3539:40: warning: array of flexible structuresmonitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3551:52: warning: array of flexible structuresmonitor/bt.h:3539:40: warning: array of flexible structures


---
Regards,
Linux Bluetooth