2023-07-28 06:00:57

by Simon Mikuda

[permalink] [raw]
Subject: [PATCH BlueZ 0/1] Adapter1.ConnectDevice

I added some minor addition to documentation and also I tested calling
function via DBus in parallel to same device.

In both case of BR/EDR both DBus calls will be pending and they will
finish at same time when Page Timeout arrives or connection. I think
this can be considered as correct behaviour.

In case of LE first one will be pending and second one will get
"org.bluez.Error.Failed: Connect failed" immediately. Later first
one will timeout.

Simon Mikuda (1):
adapter: Be able to use ConnectDevice for discovered devices

doc/adapter-api.txt | 2 +-
src/adapter.c | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)

--
2.34.1



2023-07-28 18:04:00

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [PATCH BlueZ 0/1] Adapter1.ConnectDevice

Hi Simon,

On Thu, Jul 27, 2023 at 11:00 PM Simon Mikuda
<[email protected]> wrote:
>
> I added some minor addition to documentation and also I tested calling
> function via DBus in parallel to same device.
>
> In both case of BR/EDR both DBus calls will be pending and they will
> finish at same time when Page Timeout arrives or connection. I think
> this can be considered as correct behaviour.
>
> In case of LE first one will be pending and second one will get
> "org.bluez.Error.Failed: Connect failed" immediately. Later first
> one will timeout.
>
> Simon Mikuda (1):
> adapter: Be able to use ConnectDevice for discovered devices
>
> doc/adapter-api.txt | 2 +-
> src/adapter.c | 3 ---

Please split the documentation changes from the code changes.

> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> --
> 2.34.1
>


--
Luiz Augusto von Dentz