Subject: [PATCH 1/2] client/player: Configure BASE using separate structure.

From: Claudia Draghicescu <[email protected]>

Use preset configuration in capabilities.
Configure BASE using separate structure.

---
client/player.c | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/client/player.c b/client/player.c
index 9bc5f2a36..00ab33084 100644
--- a/client/player.c
+++ b/client/player.c
@@ -1735,6 +1735,7 @@ struct endpoint_config {
struct iovec *meta;
uint8_t target_latency;
const struct codec_qos *qos;
+ struct iovec *base;
};

#define BCODE {0x01, 0x02, 0x68, 0x05, 0x53, 0xf1, 0x41, 0x5a, \
@@ -1766,6 +1767,7 @@ static void append_properties(DBusMessageIter *iter,
const char *key = "Capabilities";
const char *meta = "Metadata";
const char *keyBCode = "BroadcastCode";
+ const char *base = "BASE";

dbus_message_iter_open_container(iter, DBUS_TYPE_ARRAY, "{sv}", &dict);

@@ -1902,6 +1904,14 @@ static void append_properties(DBusMessageIter *iter,
g_dbus_dict_append_entry(&dict, "Timeout", DBUS_TYPE_UINT16,
&bcast_qos.bcast.timeout);

+ bt_shell_printf("BASE:\n");
+ bt_shell_hexdump(cfg->base->iov_base, cfg->base->iov_len);
+
+ g_dbus_dict_append_basic_array(&dict, DBUS_TYPE_STRING, &base,
+ DBUS_TYPE_BYTE,
+ &cfg->base->iov_base,
+ cfg->base->iov_len);
+
bt_shell_printf("BroadcastCode:\n");
bt_shell_hexdump(cfg->ep->bcode->iov_base, cfg->ep->bcode->iov_len);

@@ -2758,15 +2768,15 @@ static void cmd_config_endpoint(int argc, char *argv[])
if (cfg->ep->broadcast) {
iov_append(&cfg->ep->bcode, bcast_qos.bcast.bcode,
sizeof(bcast_qos.bcast.bcode));
- /* Copy capabilities for broadcast*/
- iov_append(&cfg->caps, base_lc3_16_2_1,
- sizeof(base_lc3_16_2_1));
- } else {
- /* Copy capabilities */
- iov_append(&cfg->caps, preset->data.iov_base,
- preset->data.iov_len);
+ /* Copy BASE for broadcast*/
+ iov_append(&cfg->base, base_lc3_16_2_1,
+ sizeof(base_lc3_16_2_1));
}

+ /* Copy capabilities */
+ iov_append(&cfg->caps, preset->data.iov_base,
+ preset->data.iov_len);
+
/* Set QoS parameters */
cfg->qos = &preset->qos;

--
2.34.1



2023-08-04 16:03:40

by bluez.test.bot

[permalink] [raw]
Subject: RE: Configure BASE using separate structure

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=773144

---Test result---

Test Summary:
CheckPatch PASS 1.08 seconds
GitLint FAIL 0.94 seconds
BuildEll PASS 27.90 seconds
BluezMake PASS 872.02 seconds
MakeCheck PASS 12.15 seconds
MakeDistcheck PASS 157.53 seconds
CheckValgrind PASS 256.46 seconds
CheckSmatch PASS 343.69 seconds
bluezmakeextell PASS 105.00 seconds
IncrementalBuild PASS 1430.00 seconds
ScanBuild PASS 1070.22 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[1/2] client/player: Configure BASE using separate structure.

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T3 Title has trailing punctuation (.): "[1/2] client/player: Configure BASE using separate structure."


---
Regards,
Linux Bluetooth