2023-08-08 18:20:01

by Gioele Barabucci

[permalink] [raw]
Subject: [PREFIX BlueZ 1/1] Makefile.am: Install D-Bus policy in /usr/share, not /etc

From https://bugs.debian.org/1006631:

> dbus supports policy files in both `/usr/share/dbus-1/system.d` and
> `/etc/dbus-1/systemd`. [The] recently released dbus 1.14.0, officially
> deprecates installing packages' default policies into `/etc/dbus-1/systemd`,
> instead reserving it for the sysadmin. This is the same idea as the
> difference between `/usr/lib/udev/rules.d` and `/etc/udev/rules.d`.
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 4b9b7e5cd..f23c39d20 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -32,7 +32,7 @@ confdir = $(sysconfdir)/bluetooth
statedir = $(localstatedir)/lib/bluetooth

if DATAFILES
-dbusdir = $(DBUS_CONFDIR)/dbus-1/system.d
+dbusdir = $(datadir)/dbus-1/system.d
dbus_DATA = src/bluetooth.conf

conf_DATA =
--
2.39.2



2023-08-08 20:41:36

by bluez.test.bot

[permalink] [raw]
Subject: RE: Makefile.am: Install D-Bus policy in /usr/share, not /etc

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=774181

---Test result---

Test Summary:
CheckPatch FAIL 0.65 seconds
GitLint PASS 0.32 seconds
BuildEll PASS 33.30 seconds
BluezMake PASS 1034.49 seconds
MakeCheck PASS 14.02 seconds
MakeDistcheck PASS 194.13 seconds
CheckValgrind PASS 312.82 seconds
CheckSmatch PASS 414.43 seconds
bluezmakeextell PASS 127.22 seconds
IncrementalBuild PASS 839.33 seconds
ScanBuild PASS 1292.79 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[PREFIX,BlueZ,1/1] Makefile.am: Install D-Bus policy in /usr/share, not /etc
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#61:
> deprecates installing packages' default policies into `/etc/dbus-1/systemd`,

/github/workspace/src/src/13346586.patch total: 0 errors, 1 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13346586.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth