2023-09-04 13:00:48

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ] bap: Fix not always calling bap_io_close on disconnect

From: Luiz Augusto von Dentz <[email protected]>

bap_io_disconnected was getting registered for all links while
connecting which prevented bap_io_close to be called when ISO socket is
disconnected thus the cig_active flag will remain set preventing the IO
to be recreated.
---
profiles/audio/bap.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 001a47bdc47b..9634ae4fc6c3 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -1936,6 +1936,8 @@ static void bap_connecting(struct bt_bap_stream *stream, bool state, int fd,

if (!ep->io) {
io = g_io_channel_unix_new(fd);
+ ep->io_id = g_io_add_watch(io, G_IO_HUP | G_IO_ERR | G_IO_NVAL,
+ bap_io_disconnected, ep);
ep->io = io;
} else
io = ep->io;
--
2.41.0

2023-09-05 15:59:57

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ] bap: Fix not always calling bap_io_close on disconnect

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 31 Aug 2023 15:01:37 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> bap_io_disconnected was getting registered for all links while
> connecting which prevented bap_io_close to be called when ISO socket is
> disconnected thus the cig_active flag will remain set preventing the IO
> to be recreated.
>
> [...]

Here is the summary with links:
- [BlueZ] bap: Fix not always calling bap_io_close on disconnect
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d06b912df5ab

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html