2023-10-20 23:08:28

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ v1 1/2] shared/bap: Remove Locations, Support Context and Context defines

From: Luiz Augusto von Dentz <[email protected]>

These values shall come from the upper stack.
---
src/shared/bap.c | 15 ---------------
1 file changed, 15 deletions(-)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 14a62d9241eb..13bbcf7935bd 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -48,14 +48,6 @@

#define BAP_PROCESS_TIMEOUT 10

-#define PACS_SRC_LOCATION 0x00000001
-#define PACS_SNK_LOCATION 0x00000003
-
-#define PACS_SRC_CTXT 0x000f
-#define PACS_SUPPORTED_SRC_CTXT PACS_SRC_CTXT
-#define PACS_SNK_CTXT 0x0fff
-#define PACS_SUPPORTED_SNK_CTXT PACS_SNK_CTXT
-
struct bt_bap_pac_changed {
unsigned int id;
bt_bap_pac_func_t added;
@@ -475,13 +467,6 @@ static struct bt_pacs *pacs_new(struct gatt_db *db)

pacs = new0(struct bt_pacs, 1);

- pacs->sink_loc_value = 0;
- pacs->source_loc_value = 0;
- pacs->sink_context_value = PACS_SNK_CTXT;
- pacs->source_context_value = PACS_SRC_CTXT;
- pacs->supported_sink_context_value = PACS_SUPPORTED_SNK_CTXT;
- pacs->supported_source_context_value = PACS_SUPPORTED_SRC_CTXT;
-
/* Populate DB with PACS attributes */
bt_uuid16_create(&uuid, PACS_UUID);
pacs->service = gatt_db_add_service(db, &uuid, true, 19);
--
2.41.0


2023-10-21 01:06:04

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ,v1,1/2] shared/bap: Remove Locations, Support Context and Context defines

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=795284

---Test result---

Test Summary:
CheckPatch PASS 0.98 seconds
GitLint FAIL 0.79 seconds
BuildEll PASS 39.90 seconds
BluezMake PASS 1326.81 seconds
MakeCheck PASS 14.37 seconds
MakeDistcheck PASS 252.67 seconds
CheckValgrind PASS 382.01 seconds
CheckSmatch PASS 515.82 seconds
bluezmakeextell PASS 164.13 seconds
IncrementalBuild PASS 2348.27 seconds
ScanBuild PASS 1644.54 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v1,2/2] client: Add support for setting Locations, SupportedContext and Context

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (86>80): "[BlueZ,v1,2/2] client: Add support for setting Locations, SupportedContext and Context"


---
Regards,
Linux Bluetooth