2023-11-03 18:22:07

by Jonas Dreßler

[permalink] [raw]
Subject: [PATCH BlueZ 2/4] lib/sdp: Don't assume uint8_t has size 1

Assuming the size of of uint8_t is bad practice, we use
sizeof(uint8_t) everywhere else and the use of sizeof makes it clear
we're accounting for the descriptor here rather than just randomly
subtracting 1, so change that.

Co-developed-by: Zander Brown <[email protected]>
---
lib/sdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/sdp.c b/lib/sdp.c
index 1565259a3..006ab057a 100644
--- a/lib/sdp.c
+++ b/lib/sdp.c
@@ -1505,7 +1505,7 @@ static void *sdp_data_value(sdp_data_t *data, uint32_t *len)
case SDP_TEXT_STR32:
val = data->val.str;
if (len)
- *len = data->unitSize - 1;
+ *len = data->unitSize - sizeof(uint8_t);
break;
case SDP_ALT8:
case SDP_ALT16:
--
2.41.0