2023-11-23 14:23:52

by K, Kiran

[permalink] [raw]
Subject: [PATCH] Bluetooth:btintel: Print firmware SHA1

Intel Read Version event contains a TLV(0x32) having firmware sha1 in
operational image.

Signed-off-by: Kiran K <[email protected]>
---
drivers/bluetooth/btintel.c | 5 +++++
drivers/bluetooth/btintel.h | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index 2462796a512a..cdc5c08824a0 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -535,6 +535,8 @@ static int btintel_version_info_tlv(struct hci_dev *hdev,
bt_dev_info(hdev, "%s timestamp %u.%u buildtype %u build %u", variant,
2000 + (version->timestamp >> 8), version->timestamp & 0xff,
version->build_type, version->build_num);
+ if (version->img_type == 0x03)
+ bt_dev_info(hdev, "Firmware SHA1: 0x%8.8x", version->git_sha1);

return 0;
}
@@ -630,6 +632,9 @@ static int btintel_parse_version_tlv(struct hci_dev *hdev,
memcpy(&version->otp_bd_addr, tlv->val,
sizeof(bdaddr_t));
break;
+ case INTEL_TLV_GIT_SHA1:
+ version->git_sha1 = get_unaligned_le32(tlv->val);
+ break;
default:
/* Ignore rest of information */
break;
diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
index 3a2d5b4219dd..d19fcdb9ff0b 100644
--- a/drivers/bluetooth/btintel.h
+++ b/drivers/bluetooth/btintel.h
@@ -41,7 +41,8 @@ enum {
INTEL_TLV_LIMITED_CCE,
INTEL_TLV_SBE_TYPE,
INTEL_TLV_OTP_BDADDR,
- INTEL_TLV_UNLOCKED_STATE
+ INTEL_TLV_UNLOCKED_STATE,
+ INTEL_TLV_GIT_SHA1
};

struct intel_tlv {
@@ -69,6 +70,7 @@ struct intel_version_tlv {
u8 min_fw_build_yy;
u8 limited_cce;
u8 sbe_type;
+ u32 git_sha1;
bdaddr_t otp_bd_addr;
};

--
2.34.1



2023-11-23 14:56:49

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth:btintel: Print firmware SHA1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=803732

---Test result---

Test Summary:
CheckPatch PASS 0.77 seconds
GitLint PASS 0.31 seconds
SubjectPrefix FAIL 1.45 seconds
BuildKernel PASS 27.53 seconds
CheckAllWarning PASS 30.26 seconds
CheckSparse PASS 35.44 seconds
CheckSmatch PASS 98.88 seconds
BuildKernel32 PASS 26.81 seconds
TestRunnerSetup PASS 414.87 seconds
TestRunner_l2cap-tester PASS 23.12 seconds
TestRunner_iso-tester PASS 41.17 seconds
TestRunner_bnep-tester PASS 6.92 seconds
TestRunner_mgmt-tester PASS 166.72 seconds
TestRunner_rfcomm-tester PASS 10.85 seconds
TestRunner_sco-tester PASS 14.58 seconds
TestRunner_ioctl-tester PASS 12.05 seconds
TestRunner_mesh-tester PASS 8.84 seconds
TestRunner_smp-tester PASS 9.84 seconds
TestRunner_userchan-tester PASS 7.33 seconds
IncrementalBuild PASS 26.60 seconds

Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject


---
Regards,
Linux Bluetooth

2023-11-27 15:20:40

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth:btintel: Print firmware SHA1

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 23 Nov 2023 20:05:50 +0530 you wrote:
> Intel Read Version event contains a TLV(0x32) having firmware sha1 in
> operational image.
>
> Signed-off-by: Kiran K <[email protected]>
> ---
> drivers/bluetooth/btintel.c | 5 +++++
> drivers/bluetooth/btintel.h | 4 +++-
> 2 files changed, 8 insertions(+), 1 deletion(-)

Here is the summary with links:
- Bluetooth:btintel: Print firmware SHA1
https://git.kernel.org/bluetooth/bluetooth-next/c/514525d3087c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html