2024-01-04 17:16:43

by Yao Xiao

Subject: [PATCH BlueZ v1] avdtp: Remove unused transaction parameter

From: Xiao Yao <[email protected]>

This removes unused "transaction" param from avdtp_parse_resq/rej.

Signed-off-by: Xiao Yao <[email protected]>
---
profiles/audio/avdtp.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index 10ef380d4..296439c43 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -418,11 +418,11 @@ static int send_request(struct avdtp *session, gboolean priority,
void *buffer, size_t size);
static gboolean avdtp_parse_resp(struct avdtp *session,
struct avdtp_stream *stream,
- uint8_t transaction, uint8_t signal_id,
+ uint8_t signal_id,
void *buf, int size);
static gboolean avdtp_parse_rej(struct avdtp *session,
struct avdtp_stream *stream,
- uint8_t transaction, uint8_t signal_id,
+ uint8_t signal_id,
void *buf, int size);
static int process_queue(struct avdtp *session);
static void avdtp_sep_set_state(struct avdtp *session,
@@ -2284,7 +2284,6 @@ static gboolean session_cb(GIOChannel *chan, GIOCondition cond,
switch (header->message_type) {
case AVDTP_MSG_TYPE_ACCEPT:
if (!avdtp_parse_resp(session, session->req->stream,
- session->in.transaction,
session->in.signal_id,
session->in.buf,
session->in.data_size)) {
@@ -2294,7 +2293,6 @@ static gboolean session_cb(GIOChannel *chan, GIOCondition cond,
break;
case AVDTP_MSG_TYPE_REJECT:
if (!avdtp_parse_rej(session, session->req->stream,
- session->in.transaction,
session->in.signal_id,
session->in.buf,
session->in.data_size)) {
@@ -2932,7 +2930,7 @@ static gboolean avdtp_delay_report_resp(struct avdtp *session,

static gboolean avdtp_parse_resp(struct avdtp *session,
struct avdtp_stream *stream,
- uint8_t transaction, uint8_t signal_id,
+ uint8_t signal_id,
void *buf, int size)
{
struct pending_req *next;
@@ -3046,7 +3044,7 @@ static gboolean stream_rej_to_err(struct stream_rej *rej, unsigned int size,

static gboolean avdtp_parse_rej(struct avdtp *session,
struct avdtp_stream *stream,
- uint8_t transaction, uint8_t signal_id,
+ uint8_t signal_id,
void *buf, int size)
{
struct avdtp_error err;
--
2.34.1

2024-01-04 18:30:47

by bluez.test.bot

Subject: RE: [BlueZ,v1] avdtp: Remove unused transaction parameter

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=814434

---Test result---

Test Summary:
CheckPatch PASS 0.28 seconds
GitLint PASS 0.20 seconds
BuildEll PASS 24.28 seconds
BluezMake PASS 717.52 seconds
MakeCheck PASS 11.78 seconds
MakeDistcheck PASS 160.92 seconds
CheckValgrind PASS 222.79 seconds
CheckSmatch PASS 326.78 seconds
bluezmakeextell PASS 107.29 seconds
IncrementalBuild PASS 670.83 seconds
ScanBuild PASS 967.26 seconds



---
Regards,
Linux Bluetooth