2024-01-11 10:07:52

by Neeraj Sanjay Kale

[permalink] [raw]
Subject: [PATCH v1] Bluetooth: btnxpuart: Disable Power Save feature on startup

This sets the default power save mode setting to enabled.
The power save feature is now stable and stress test issues,
such as the TX timeout error, has been resolved.
With this setting, the driver will send the vendor command
to FW at startup, to enable power save feature.
User can disable this feature using the following vendor
command:
hcitool cmd 3f 23 03 00 00 (HCI_NXP_AUTO_SLEEP_MODE)

Signed-off-by: Neeraj Sanjay Kale <[email protected]>
---
drivers/bluetooth/btnxpuart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 7f88b6f52f26..42e929f0d141 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -281,7 +281,7 @@ static u8 crc8_table[CRC8_TABLE_SIZE];

/* Default configurations */
#define DEFAULT_H2C_WAKEUP_MODE WAKEUP_METHOD_BREAK
-#define DEFAULT_PS_MODE PS_MODE_DISABLE
+#define DEFAULT_PS_MODE PS_MODE_ENABLE
#define FW_INIT_BAUDRATE HCI_NXP_PRI_BAUDRATE

static struct sk_buff *nxp_drv_send_cmd(struct hci_dev *hdev, u16 opcode,
--
2.34.1



2024-01-11 10:34:26

by bluez.test.bot

[permalink] [raw]
Subject: RE: [v1] Bluetooth: btnxpuart: Disable Power Save feature on startup

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=816084

---Test result---

Test Summary:
CheckPatch PASS 0.46 seconds
GitLint PASS 0.21 seconds
SubjectPrefix PASS 0.07 seconds
BuildKernel PASS 27.63 seconds
CheckAllWarning PASS 30.42 seconds
CheckSparse PASS 35.85 seconds
CheckSmatch PASS 98.03 seconds
BuildKernel32 PASS 27.04 seconds
TestRunnerSetup PASS 432.04 seconds
TestRunner_l2cap-tester PASS 23.37 seconds
TestRunner_iso-tester FAIL 60.48 seconds
TestRunner_bnep-tester PASS 6.93 seconds
TestRunner_mgmt-tester FAIL 168.04 seconds
TestRunner_rfcomm-tester PASS 11.03 seconds
TestRunner_sco-tester PASS 15.01 seconds
TestRunner_ioctl-tester PASS 12.10 seconds
TestRunner_mesh-tester PASS 8.68 seconds
TestRunner_smp-tester PASS 9.69 seconds
TestRunner_userchan-tester PASS 7.19 seconds
IncrementalBuild PASS 25.61 seconds

Details
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 117, Passed: 116 (99.1%), Failed: 1, Not Run: 0

Failed Test Cases
ISO Connect Suspend - Success Failed 10.353 seconds
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 497, Passed: 495 (99.6%), Failed: 1, Not Run: 1

Failed Test Cases
LL Privacy - Set Device Flag 1 (Device Privacy) Failed 0.247 seconds


---
Regards,
Linux Bluetooth