2024-01-23 15:41:13

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ v1] isotest: Fix not handling 0 length packets

From: Luiz Augusto von Dentz <[email protected]>

It is in fact possible to receive 0 length packets since that probably
means their status is not sucess.
---
tools/isotest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/isotest.c b/tools/isotest.c
index 771d24b6d2a6..7e875fa58b15 100644
--- a/tools/isotest.c
+++ b/tools/isotest.c
@@ -642,7 +642,7 @@ static void dump_mode(int fd, int sk, char *peer)
}

syslog(LOG_INFO, "Receiving ...");
- while ((len = read(sk, buf, data_size)) > 0) {
+ while ((len = read(sk, buf, data_size)) >= 0) {
if (fd >= 0) {
len = write(fd, buf, len);
if (len < 0) {
@@ -680,7 +680,7 @@ static void recv_mode(int fd, int sk, char *peer)
int r;

r = recv(sk, buf, data_size, 0);
- if (r <= 0) {
+ if (r < 0) {
if (r < 0)
syslog(LOG_ERR, "Read failed: %s (%d)",
strerror(errno), errno);
--
2.43.0



2024-01-23 16:34:06

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ,v1] isotest: Fix not handling 0 length packets

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=819151

---Test result---

Test Summary:
CheckPatch FAIL 0.67 seconds
GitLint PASS 0.28 seconds
BuildEll PASS 24.13 seconds
BluezMake PASS 742.53 seconds
MakeCheck PASS 11.46 seconds
MakeDistcheck PASS 161.37 seconds
CheckValgrind PASS 222.53 seconds
CheckSmatch PASS 342.82 seconds
bluezmakeextell PASS 114.90 seconds
IncrementalBuild PASS 695.80 seconds
ScanBuild PASS 942.32 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v1] isotest: Fix not handling 0 length packets
WARNING:TYPO_SPELLING: 'sucess' may be misspelled - perhaps 'success'?
#92:
means their status is not sucess.
^^^^^^

/github/workspace/src/src/13527606.patch total: 0 errors, 1 warnings, 16 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13527606.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth