2024-02-16 21:40:37

by Hans de Goede

[permalink] [raw]
Subject: [PATCH] Bluetooth: hci_bcm: Limit bcm43455 baudrate to 2000000

Like the bcm43430a0 the bcm43455 BT does not support the 0xfc45 command
to set the UART clock to 48 MHz and because of this it does not work
at 4000000 baud.

These chips are found on ACPI/x86 devices where the operating baudrate
does not come from the firmware but is hardcoded at 4000000, which does
not work.

Make the driver_data for the "BCM2EA4" ACPI HID which is used for
the bcm43455 BT point to bcm43430_device_data which limits the baudrate
to 2000000.

Signed-off-by: Hans de Goede <[email protected]>
---
drivers/bluetooth/hci_bcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 874d23089b39..85471be0c71a 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1487,7 +1487,7 @@ static const struct acpi_device_id bcm_acpi_match[] = {
{ "BCM2EA1" },
{ "BCM2EA2", (long)&bcm43430_device_data },
{ "BCM2EA3", (long)&bcm43430_device_data },
- { "BCM2EA4" },
+ { "BCM2EA4", (long)&bcm43430_device_data }, /* bcm43455 */
{ "BCM2EA5" },
{ "BCM2EA6" },
{ "BCM2EA7" },
--
2.43.0



2024-02-16 22:32:44

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: hci_bcm: Limit bcm43455 baudrate to 2000000

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=826948

---Test result---

Test Summary:
CheckPatch PASS 2.29 seconds
GitLint PASS 0.29 seconds
SubjectPrefix PASS 0.11 seconds
BuildKernel PASS 27.68 seconds
CheckAllWarning PASS 30.71 seconds
CheckSparse PASS 35.87 seconds
CheckSmatch PASS 99.61 seconds
BuildKernel32 PASS 27.12 seconds
TestRunnerSetup PASS 500.52 seconds
TestRunner_l2cap-tester PASS 18.07 seconds
TestRunner_iso-tester PASS 31.03 seconds
TestRunner_bnep-tester PASS 4.81 seconds
TestRunner_mgmt-tester FAIL 167.55 seconds
TestRunner_rfcomm-tester PASS 7.43 seconds
TestRunner_sco-tester PASS 10.93 seconds
TestRunner_ioctl-tester PASS 7.83 seconds
TestRunner_mesh-tester PASS 8.35 seconds
TestRunner_smp-tester PASS 6.92 seconds
TestRunner_userchan-tester PASS 4.99 seconds
IncrementalBuild PASS 26.17 seconds

Details
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 488 (99.2%), Failed: 3, Not Run: 1

Failed Test Cases
LL Privacy - Add Device 4 (2 Devices to AL) Failed 0.119 seconds
LL Privacy - Add Device 6 (RL is full) Failed 0.146 seconds
LL Privacy - Remove Device 4 (Disable Adv) Timed out 1.879 seconds


---
Regards,
Linux Bluetooth