2024-03-13 09:04:47

by Vlad Pruteanu

[permalink] [raw]
Subject: [PATCH BlueZ 0/1] client/player: Update minimum LC3 SDU size to accommodate 8_1 config

Currently the minimum LC3 SDU size is set to 30B. Thus, if a source
uses the 8_1_1 config which has a SDU size of 26 the sink's capabilities
won't match and the appropriate endpoint won't be created.

Vlad Pruteanu (1):
client/player: Update minimum LC3 SDU size to accommodate 8_1 config

client/player.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

--
2.39.2



2024-03-13 09:05:28

by Vlad Pruteanu

[permalink] [raw]
Subject: [PATCH BlueZ 1/1] client/player: Update minimum LC3 SDU size to accommodate 8_1 config

Currently the minimum LC3 SDU size is set to 30B. Thus, if a source
uses the 8_1_1 config which has a SDU size of 26 the sink's capabilities
won't match and the appropriate endpoint won't be created.
---
client/player.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/client/player.c b/client/player.c
index a40bf66e3..30bcfb95d 100644
--- a/client/player.c
+++ b/client/player.c
@@ -1188,10 +1188,10 @@ static const struct capabilities {
* Frequencies: 8Khz 11Khz 16Khz 22Khz 24Khz 32Khz 44.1Khz 48Khz
* Duration: 7.5 ms 10 ms
* Channel count: 3
- * Frame length: 30-240
+ * Frame length: 26-240
*/
CODEC_CAPABILITIES("pac_snk/lc3", PAC_SINK_UUID, LC3_ID,
- LC3_DATA(LC3_FREQ_ANY, LC3_DURATION_ANY, 3u, 30,
+ LC3_DATA(LC3_FREQ_ANY, LC3_DURATION_ANY, 3u, 26,
240),
UTIL_IOV_INIT()),

@@ -1200,10 +1200,10 @@ static const struct capabilities {
* Frequencies: 8Khz 11Khz 16Khz 22Khz 24Khz 32Khz 44.1Khz 48Khz
* Duration: 7.5 ms 10 ms
* Channel count: 3
- * Frame length: 30-240
+ * Frame length: 26-240
*/
CODEC_CAPABILITIES("pac_src/lc3", PAC_SOURCE_UUID, LC3_ID,
- LC3_DATA(LC3_FREQ_ANY, LC3_DURATION_ANY, 3u, 30,
+ LC3_DATA(LC3_FREQ_ANY, LC3_DURATION_ANY, 3u, 26,
240),
UTIL_IOV_INIT()),

@@ -1212,10 +1212,10 @@ static const struct capabilities {
* Frequencies: 8Khz 11Khz 16Khz 22Khz 24Khz 32Khz 44.1Khz 48Khz
* Duration: 7.5 ms 10 ms
* Channel count: 3
- * Frame length: 30-240
+ * Frame length: 26-240
*/
CODEC_CAPABILITIES("bcaa/lc3", BCAA_SERVICE_UUID, LC3_ID,
- LC3_DATA(LC3_FREQ_ANY, LC3_DURATION_ANY, 3u, 30,
+ LC3_DATA(LC3_FREQ_ANY, LC3_DURATION_ANY, 3u, 26,
240),
UTIL_IOV_INIT()),

@@ -1224,10 +1224,10 @@ static const struct capabilities {
* Frequencies: 8Khz 11Khz 16Khz 22Khz 24Khz 32Khz 44.1Khz 48Khz
* Duration: 7.5 ms 10 ms
* Channel count: 3
- * Frame length: 30-240
+ * Frame length: 26-240
*/
CODEC_CAPABILITIES("baa/lc3", BAA_SERVICE_UUID, LC3_ID,
- LC3_DATA(LC3_FREQ_ANY, LC3_DURATION_ANY, 3u, 30,
+ LC3_DATA(LC3_FREQ_ANY, LC3_DURATION_ANY, 3u, 26,
240),
UTIL_IOV_INIT()),
};
--
2.39.2


2024-03-13 10:39:48

by bluez.test.bot

[permalink] [raw]
Subject: RE: client/player: Update minimum LC3 SDU size to accommodate 8_1 config

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=834885

---Test result---

Test Summary:
CheckPatch PASS 0.44 seconds
GitLint PASS 0.31 seconds
BuildEll PASS 24.21 seconds
BluezMake PASS 1698.32 seconds
MakeCheck PASS 13.17 seconds
MakeDistcheck PASS 176.84 seconds
CheckValgrind PASS 247.68 seconds
CheckSmatch PASS 350.18 seconds
bluezmakeextell PASS 119.81 seconds
IncrementalBuild PASS 1458.97 seconds
ScanBuild PASS 1010.77 seconds



---
Regards,
Linux Bluetooth

2024-03-14 14:50:36

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH BlueZ 0/1] client/player: Update minimum LC3 SDU size to accommodate 8_1 config

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 13 Mar 2024 11:03:58 +0200 you wrote:
> Currently the minimum LC3 SDU size is set to 30B. Thus, if a source
> uses the 8_1_1 config which has a SDU size of 26 the sink's capabilities
> won't match and the appropriate endpoint won't be created.
>
> Vlad Pruteanu (1):
> client/player: Update minimum LC3 SDU size to accommodate 8_1 config
>
> [...]

Here is the summary with links:
- [BlueZ,1/1] client/player: Update minimum LC3 SDU size to accommodate 8_1 config
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=84628e5d109c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html