2024-05-06 07:41:30

by Naga Bhavani Akella

[permalink] [raw]
Subject: [PATCH v1] Bluez: unregister-includes option is not working in bluetoothctl

unregister includes option takes two parameters service uuid and
included service uuid, since the space between them is missing,
the menu option is not working.
When two uuids separated with space is given, it is throwing error.

Signed-off-by: Naga Bhavani Akella <[email protected]>
---
client/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/main.c b/client/main.c
index 51d08a67a..c8b0f7f1c 100644
--- a/client/main.c
+++ b/client/main.c
@@ -3060,7 +3060,7 @@ static const struct bt_shell_menu gatt_menu = {
"Unregister application service" },
{ "register-includes", "<UUID> [handle]", cmd_register_includes,
"Register as Included service in." },
- { "unregister-includes", "<Service-UUID><Inc-UUID>",
+ { "unregister-includes", "<Service-UUID> <Inc-UUID>",
cmd_unregister_includes,
"Unregister Included service." },
{ "register-characteristic",
--


2024-05-06 09:44:08

by bluez.test.bot

[permalink] [raw]
Subject: RE: [v1] Bluez: unregister-includes option is not working in bluetoothctl

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=850695

---Test result---

Test Summary:
CheckPatch PASS 0.37 seconds
GitLint PASS 0.41 seconds
BuildEll PASS 24.73 seconds
BluezMake PASS 1695.16 seconds
MakeCheck PASS 13.70 seconds
MakeDistcheck PASS 184.12 seconds
CheckValgrind PASS 253.21 seconds
CheckSmatch PASS 353.00 seconds
bluezmakeextell PASS 119.61 seconds
IncrementalBuild PASS 1494.55 seconds
ScanBuild PASS 999.77 seconds



---
Regards,
Linux Bluetooth

2024-05-06 16:30:34

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH v1] Bluez: unregister-includes option is not working in bluetoothctl

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Mon, 6 May 2024 13:10:43 +0530 you wrote:
> unregister includes option takes two parameters service uuid and
> included service uuid, since the space between them is missing,
> the menu option is not working.
> When two uuids separated with space is given, it is throwing error.
>
> Signed-off-by: Naga Bhavani Akella <[email protected]>
>
> [...]

Here is the summary with links:
- [v1] Bluez: unregister-includes option is not working in bluetoothctl
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=78af547e94d9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html