2024-06-13 13:49:06

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ v1] client/player: Fix transport.send

From: Luiz Augusto von Dentz <[email protected]>

This fixes the usage of getpeername, introduced by 04153538aaf4
("client/player: Fix using unicast QoS for broadcast"), without
initializing optlen which causes the following problem:

Unable to send: Operation not permitted (1)
---
client/player.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/client/player.c b/client/player.c
index df5cb892428a..7a7598c397af 100644
--- a/client/player.c
+++ b/client/player.c
@@ -5140,7 +5140,7 @@ static void cmd_send_transport(int argc, char *argv[])
err = transport_send(transport, fd, NULL);
} else {
struct sockaddr_iso addr;
- socklen_t optlen;
+ socklen_t optlen = sizeof(addr);

err = getpeername(transport->sk, &addr, &optlen);
if (!err) {
@@ -5154,7 +5154,7 @@ static void cmd_send_transport(int argc, char *argv[])
}

if (err < 0) {
- bt_shell_printf("Unable to send: %s (%d)",
+ bt_shell_printf("Unable to send: %s (%d)\n",
strerror(-err), -err);
close(fd);
return bt_shell_noninteractive_quit(EXIT_FAILURE);
--
2.45.2

2024-06-13 17:40:38

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ v1] client/player: Fix transport.send

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 13 Jun 2024 09:48:54 -0400 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> This fixes the usage of getpeername, introduced by 04153538aaf4
> ("client/player: Fix using unicast QoS for broadcast"), without
> initializing optlen which causes the following problem:
>
> Unable to send: Operation not permitted (1)
>
> [...]

Here is the summary with links:
- [BlueZ,v1] client/player: Fix transport.send
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7861c511ca7e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html