2023-09-17 16:59:24

by Paul Menzel

[permalink] [raw]
Subject: Re: [PATCH] configure.ac: Add enable_btpclient and enable_mesh for internal ELL

Dear Koba,


Thank you for your patch. I think you should tag your patch with BlueZ
in the commit message summary.

Am 17.09.23 um 18:50 schrieb Koba Ko:
> when enable_external_ell is not specified, confiugre doesn't not check

configu*re*

> if enable_btpclient and enable_mesh are enabled.
> this causes the internal ELL must be installed.

It’d be great, if you rephrased the last sentence, as I have a hard time
to understand it.

> Signed-off-by: Koba Ko <[email protected]>
> ---
> configure.ac | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 4186c3792..9897d36d6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -301,7 +301,8 @@ if (test "${enable_external_ell}" = "yes"); then
> AC_SUBST(ELL_CFLAGS)
> AC_SUBST(ELL_LIBS)
> fi
> -if (test "${enable_external_ell}" != "yes"); then
> +if (test "${enable_external_ell}" != "yes" &&
> + (test "${enable_btpclient}" = "yes" && test "${enable_mesh}" = "yes")); then
> if (test ! -f ${srcdir}/ell/ell.h) &&
> (test ! -f ${srcdir}/../ell/ell/ell.h); then
> AC_MSG_ERROR(ELL source is required or use --enable-external-ell)


Kind regards,

Paul