2009-09-10 17:40:34

by SephirXV

Subject: [PATCH 3/3] Hidraw: ioctl to expose 'uniq'

From: Christopher Olson <[email protected]>

Simple, deterministic way of getting uniq field bound to hidrawN
files. Flame me on this one, so long as I get some feedback I can use.

Signed-off-by: Christopher Olson <[email protected]>

---

--- drivers/hid/hidraw.c 2009-09-10 10:32:28.000000000 -0500
+++ drivers/hid/hidraw.c.1 2009-09-10 10:32:13.000000000 -0500
@@ -264,6 +264,12 @@ static long hidraw_ioctl(struct file *fi
ret = -EFAULT;
break;
}
+ case HIDIOCGRAWINFO + 1: //HIDIOCG_UNIQ
+ {
+ if (copy_to_user(user_arg, dev->hid->uniq, 64))
+ ret = -EFAULT;
+ break;
+ }
default:
ret = -ENOTTY;
}

2009-09-10 17:51:18

by Marcel Holtmann

Subject: Re: [PATCH 3/3] Hidraw: ioctl to expose 'uniq'

Hi Christopher,

> Simple, deterministic way of getting uniq field bound to hidrawN
> files. Flame me on this one, so long as I get some feedback I can use.
>
> Signed-off-by: Christopher Olson <[email protected]>
>
> ---
>
> --- drivers/hid/hidraw.c 2009-09-10 10:32:28.000000000 -0500
> +++ drivers/hid/hidraw.c.1 2009-09-10 10:32:13.000000000 -0500
> @@ -264,6 +264,12 @@ static long hidraw_ioctl(struct file *fi
> ret = -EFAULT;
> break;
> }
> + case HIDIOCGRAWINFO + 1: //HIDIOCG_UNIQ
> + {
> + if (copy_to_user(user_arg, dev->hid->uniq, 64))
> + ret = -EFAULT;
> + break;
> + }
> default:
> ret = -ENOTTY;
> }

wrong mailing list to begin with.

Regards

Marcel