2018-03-27 15:38:20

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ] gatt: Fix checking for paired flag instead of bonded

From: Luiz Augusto von Dentz <[email protected]>

Device state should remain valid for devices that are bonded/stored not
only paired.
---
src/gatt-database.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gatt-database.c b/src/gatt-database.c
index 2c2526f74..5e2390b34 100644
--- a/src/gatt-database.c
+++ b/src/gatt-database.c
@@ -324,7 +324,7 @@ static void att_disconnected(int err, void *user_data)
if (!device)
goto remove;

- if (device_is_paired(device, state->bdaddr_type))
+ if (device_is_bonded(device, state->bdaddr_type))
return;

remove:
@@ -1125,7 +1125,7 @@ static void send_notification_to_device(void *data, void *user_data)

server = btd_device_get_gatt_server(device);
if (!server) {
- if (!device_is_paired(device, device_state->bdaddr_type))
+ if (!device_is_bonded(device, device_state->bdaddr_type))
goto remove;
state_set_pending(device_state, notify);
return;
--
2.14.3

2018-03-28 06:44:06

by Szymon Janc

Subject: Re: [PATCH BlueZ] gatt: Fix checking for paired flag instead of bonded

Hi Luiz,

On Tuesday, 27 March 2018 17:38:20 CEST Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> Device state should remain valid for devices that are bonded/stored not
> only paired.
> ---
> src/gatt-database.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gatt-database.c b/src/gatt-database.c
> index 2c2526f74..5e2390b34 100644
> --- a/src/gatt-database.c
> +++ b/src/gatt-database.c
> @@ -324,7 +324,7 @@ static void att_disconnected(int err, void *user_data)
> if (!device)
> goto remove;
>
> - if (device_is_paired(device, state->bdaddr_type))
> + if (device_is_bonded(device, state->bdaddr_type))
> return;
>
> remove:
> @@ -1125,7 +1125,7 @@ static void send_notification_to_device(void *data,
> void *user_data)
>
> server = btd_device_get_gatt_server(device);
> if (!server) {
> - if (!device_is_paired(device, device_state->bdaddr_type))
> + if (!device_is_bonded(device, device_state->bdaddr_type))
> goto remove;
> state_set_pending(device_state, notify);
> return;

Applied, thanks.

--
pozdrawiam
Szymon Janc