From: Martin <[email protected]>
The definition of Target should be the same with Target parameter
of CreateSession.
And add TargetUUID to save the Obex service UUID
---
doc/obex-api.txt | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/doc/obex-api.txt b/doc/obex-api.txt
index 22449c4..ad03690 100644
--- a/doc/obex-api.txt
+++ b/doc/obex-api.txt
@@ -67,7 +67,15 @@ Properties string Source [readonly]
Bluetooth channel
string Target [readonly]
+ The currently supported targets are the following:
+
+ "ftp"
+ "map"
+ "opp"
+ "pbap"
+ "sync"
+ string TargetUUID [readonly]
Target UUID
string Root [readonly]
--
1.7.10.4
Hi Luiz:
> -----Original Message-----
> From: [email protected] [mailto:linux-bluetooth-
> [email protected]] On Behalf Of Luiz Augusto von Dentz
> Sent: Tuesday, July 16, 2013 19:37
> To: [email protected]
> Cc: [email protected]
> Subject: Re: [PATCH] Obex/Session: Redefine session target property
>
> Hi Martin,
>
> On Mon, Jul 15, 2013 at 5:10 AM, <[email protected]> wrote:
> > From: Martin <[email protected]>
> >
> > The definition of Target should be the same with Target parameter of
> > CreateSession.
> >
> > And add TargetUUID to save the Obex service UUID
> > ---
> > doc/obex-api.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/doc/obex-api.txt b/doc/obex-api.txt index
> > 22449c4..ad03690 100644
> > --- a/doc/obex-api.txt
> > +++ b/doc/obex-api.txt
> > @@ -67,7 +67,15 @@ Properties string Source [readonly]
> > Bluetooth channel
> >
> > string Target [readonly]
> > + The currently supported targets are the
> following:
> > +
> > + "ftp"
> > + "map"
> > + "opp"
> > + "pbap"
> > + "sync"
> >
> > + string TargetUUID [readonly]
> > Target UUID
> >
> > string Root [readonly]
> > --
> > 1.7.10.4
>
> I wonder what is the benefit of yet another property, would the UI
> double check if the UUID matches the friendly name? I like to see the
> use case in the description so we really tell how it is going to be
> used, otherwise Target is fine. Btw, for OPP there is as actually a
> UUID as well:
>
> static struct obc_driver opp = {
> .service = "OPP",
> .uuid = OPP_UUID,
> .probe = opp_probe,
> .remove = opp_remove
> };
The target head of OPP is not used see
SIG OBJECT PUSH PROFILE v.12 Section 5.4. At this situation it is not
Proper for UI to decide the session type by Can't the TargetUUID.
Furthermore, we need to make Target comply with that in CreateSession target parameter
And it is friendly to UI to get the session type, otherwise, UI needs to check the UUID.
Of course we need to use TargetUUID on external profile.
Hi Martin,
On Mon, Jul 15, 2013 at 5:10 AM, <[email protected]> wrote:
> From: Martin <[email protected]>
>
> The definition of Target should be the same with Target parameter
> of CreateSession.
>
> And add TargetUUID to save the Obex service UUID
> ---
> doc/obex-api.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/obex-api.txt b/doc/obex-api.txt
> index 22449c4..ad03690 100644
> --- a/doc/obex-api.txt
> +++ b/doc/obex-api.txt
> @@ -67,7 +67,15 @@ Properties string Source [readonly]
> Bluetooth channel
>
> string Target [readonly]
> + The currently supported targets are the following:
> +
> + "ftp"
> + "map"
> + "opp"
> + "pbap"
> + "sync"
>
> + string TargetUUID [readonly]
> Target UUID
>
> string Root [readonly]
> --
> 1.7.10.4
I wonder what is the benefit of yet another property, would the UI
double check if the UUID matches the friendly name? I like to see the
use case in the description so we really tell how it is going to be
used, otherwise Target is fine. Btw, for OPP there is as actually a
UUID as well:
static struct obc_driver opp = {
.service = "OPP",
.uuid = OPP_UUID,
.probe = opp_probe,
.remove = opp_remove
};
So I wonder if we should just update the documentation, anyway with
ObjectManager we do get the interfaces with InterfacesAdded signal so
you can tell what type of session is that from the interfaces it
supports, the friendly names in the CreateSession are supported just
for convenience but they map to UUIDs anyway.
--
Luiz Augusto von Dentz