2009-04-22 12:16:43

by alok barsode

[permalink] [raw]
Subject: [PATCH][HCIRAW] Initial proposal for hciraw plugin.

Hi Marcel,

Here are the initial patches for hciraw plugin.

I have pulled the IO event stuff from main.c to hciraw.c

Let me know what you think.

Cheers,
Alok.


Attachments:
0001-Initialing-HCI-raw-socket-plugin-hciraw.patch (2.64 kB)
0002-exporting-device_event.patch (2.36 kB)
0003-Using-device_event-to-register-and-setup-already-kno.patch (880.00 B)
0004-Initializing-hci-raw-socket-plugin.-Adding-IO-event.patch (7.33 kB)
Download all attachments

2009-04-23 12:09:37

by alok barsode

[permalink] [raw]
Subject: Re: [PATCH][HCIRAW] Initial proposal for hciraw plugin.

Hi Luiz/Marcel

On Thu, Apr 23, 2009 at 12:52 AM, Luiz Augusto von Dentz
<[email protected]> wrote:
> Hi Alok,
>
> On Wed, Apr 22, 2009 at 9:16 AM, alok barsode <[email protected]> wrote:
>> Hi Marcel,
>>
>> Here are the initial patches for hciraw plugin.
>>
>> I have pulled the IO event stuff from main.c to hciraw.c
>>
>> Let me know what you think.
>>
>> Cheers,
>> Alok.
>>
>
> The logic on Using-device_event-to-register-and-setup-already-kno.patch
> seems to be wrong, it will not do what the current code does which is
> to always register the adapter and in case of being up initialize it.
>
yup its wrong. it wouldn't register already known "down" adapters. the
devup logic was wrong too.
Thanks for catching this.

Sending new patches which fix this. These are against the latest tree (rel 4.37)
Let me know what you think.

> --
> Luiz Augusto von Dentz
> Engenheiro de Computa??o
>

Cheers,
Alok.


Attachments:
0001-Initialing-HCI-raw-socket-plugin-hciops.patch (2.64 kB)
0002-exporting-device_event.patch (2.36 kB)
0003-Modifying-device_devreg_setup.-Check-if-device-is-up.patch (1.63 kB)
0004-Using-device_event-to-register-and-setup-already-kno.patch (916.00 B)
0005-Initializing-hciops-plugin.-Adding-IO-event-handing.patch (7.32 kB)
Download all attachments

2009-04-22 19:22:14

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [PATCH][HCIRAW] Initial proposal for hciraw plugin.

Hi Alok,

On Wed, Apr 22, 2009 at 9:16 AM, alok barsode <[email protected]> wrote=
:
> Hi Marcel,
>
> Here are the initial patches for hciraw plugin.
>
> I have pulled the IO event stuff from main.c to hciraw.c
>
> Let me know what you think.
>
> Cheers,
> Alok.
>

The logic on Using-device_event-to-register-and-setup-already-kno.patch
seems to be wrong, it will not do what the current code does which is
to always register the adapter and in case of being up initialize it.

--=20
Luiz Augusto von Dentz
Engenheiro de Computa=E7=E3o