2010-12-10 12:19:33

by roystonr

[permalink] [raw]
Subject: Re: A2DP reconfigure with BMW Carkit (supporting multi streams) timeouts.

Hi Johan/Luiz,

> On Fri, Dec 10, 2010, Luiz Augusto von Dentz wrote:
> I guess it would be better to have the call to
> avdtp_stream_get_remote_sep on close_cfm, it is probably safer to do
> there and less code too, but the fix is probably right.

Along with this as per my understanding, struct avdtp_remote_sep *rsep has
to be added as member to struct a2dp_setup and rsep should be overridden
as follows in a2dp_reconfigure after call to avdtp_get_seps which returns
the sep corresponding to the stream not in use. If the remote device
supports multi-stream then sep returned would be based on the order of
get_capabilities response. Hence the following override is needed to
ensure that closed stream is reconfigured. Correct me if mistaken.

if (setup->rsep) {
rsep = setup->rsep;
}

Have provided the patch to the tester to verify as we don't have the BMW
CK available locally. Would update the feedback received.

Regards,
Royston Rodrigues





2011-02-01 14:16:42

by Lukasz Rymanowski

[permalink] [raw]
Subject: Re: A2DP reconfigure with BMW Carkit (supporting multi streams) timeouts.

Hi Roystonr,

> Have provided the patch to the tester to verify as we don't have the BMW
> CK available locally. Would update the feedback received.

I'm just wondering, Is it working for you ?

>
> Regards,
> Royston Rodrigues
>

Regards
\Lukasz