2020-03-13 05:19:02

by Amit K Bag

Subject: [PATCH v3] Bluetooth: print fw build version in power-on boot

From: Sukumar Ghorai <[email protected]>

To determine the build version of Bluetooth firmware to ensure reported
issue related to a particular release. This is very helpful for every fw
downloaded to BT controller and issue reported from field test.

Signed-off-by: Amit K Bag <[email protected]>
Signed-off-by: Sukumar Ghorai <[email protected]>
---
drivers/bluetooth/btusb.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f5924f3e8b8d..db6211f34300 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1930,7 +1930,14 @@ static int btusb_setup_intel(struct hci_dev *hdev)
if (err)
return err;

- bt_dev_info(hdev, "Intel firmware patch completed and activated");
+ /* Need build number for downloaded fw patches in
+ * every power-on boot
+ */
+ err = btintel_read_version(hdev, &ver);
+ if (err)
+ return err;
+ bt_dev_info(hdev, "Intel BT fw patch 0x%02x completed & activated",
+ ver.fw_patch_num);

goto complete;

--
2.17.1

2020-03-13 18:51:18

by Marcel Holtmann

Subject: Re: [PATCH v3] Bluetooth: print fw build version in power-on boot

Hi Amit,

> To determine the build version of Bluetooth firmware to ensure reported
> issue related to a particular release. This is very helpful for every fw
> downloaded to BT controller and issue reported from field test.
>
> Signed-off-by: Amit K Bag <[email protected]>
> Signed-off-by: Sukumar Ghorai <[email protected]>
> ---
> drivers/bluetooth/btusb.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)

I have two v3 versions in my inbox. Please send me a clean v4 that is ready to be applied so that I don’t have to second guess.

Regards

Marcel