2012-03-26 06:44:55

by Joohi RASTOGI

Subject: [PATCH Bluez] avcrp: Fix response length for unit info command.

Hi,

Fixed response length for Unit Info command. This affect PTS Test Case for TC_TG_ICC_BV_01_I.

>From f03c6037836bf8ef5253f8d87edb8ec2db0742af Mon Sep 17 00:00:00 2001
From: Joohi Rastogi <[email protected]>
Date: Mon, 26 Mar 2012 11:53:19 +0530
Subject: [PATCH Bluez] avcrp: Fix response length for unit info command.

---
audio/avctp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/avctp.c b/audio/avctp.c
index dfad9fd..5b84977 100644
--- a/audio/avctp.c
+++ b/audio/avctp.c
@@ -268,7 +268,7 @@ static size_t handle_unit_info(struct avctp *session,

DBG("reply to AVC_OP_UNITINFO");

- return 0;
+ return operand_count;
}

static size_t handle_subunit_info(struct avctp *session,
--
1.7.5.4

-Joohi Rastogi

2012-03-27 12:04:24

by Johan Hedberg

Subject: Re: [PATCH Bluez V2] avcrp: Fix response length for unit info command.

Hi,

On Tue, Mar 27, 2012, Joohi RASTOGI wrote:
> Hi,
>
> Fixed response length for Unit Info command. This affect PTS Test Case TC_TG_ICC_BV_01_I.
> Changed the acronym AVRCP to uppercase.
>
> From c4b1ac44ca4b608c550e8cb0b12c3b04d65aa05d Mon Sep 17 00:00:00 2001
> From: Joohi Rastogi <[email protected]>
> Date: Mon, 26 Mar 2012 11:53:19 +0530
> Subject: [PATCH] AVRCP: Fix response length for unit info command.
>
> ---
> audio/avctp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/avctp.c b/audio/avctp.c
> index dfad9fd..5b84977 100644
> --- a/audio/avctp.c
> +++ b/audio/avctp.c
> @@ -268,7 +268,7 @@ static size_t handle_unit_info(struct avctp *session,
>
> DBG("reply to AVC_OP_UNITINFO");
>
> - return 0;
> + return operand_count;
> }
>
> static size_t handle_subunit_info(struct avctp *session,

Could you please resend both of your patches with git send-email (or if
you really are unable to use git send-email send them as attachments).
As they are right now I'm failing to pass them to "git am" from your
emails. Also, please include the references to the PTS test cases in the
commit message instead of having that somewhere external.

Johan

2012-03-27 10:35:22

by Joohi RASTOGI

Subject: [PATCH Bluez V2] avcrp: Fix response length for unit info command.

Hi,

Fixed response length for Unit Info command. This affect PTS Test Case TC_TG_ICC_BV_01_I.
Changed the acronym AVRCP to uppercase.

>From c4b1ac44ca4b608c550e8cb0b12c3b04d65aa05d Mon Sep 17 00:00:00 2001
From: Joohi Rastogi <[email protected]>
Date: Mon, 26 Mar 2012 11:53:19 +0530
Subject: [PATCH] AVRCP: Fix response length for unit info command.

---
audio/avctp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/avctp.c b/audio/avctp.c
index dfad9fd..5b84977 100644
--- a/audio/avctp.c
+++ b/audio/avctp.c
@@ -268,7 +268,7 @@ static size_t handle_unit_info(struct avctp *session,

DBG("reply to AVC_OP_UNITINFO");

- return 0;
+ return operand_count;
}

static size_t handle_subunit_info(struct avctp *session,
--
1.7.5.4

-Joohi Rastogi

2012-03-26 14:19:27

by Luiz Augusto von Dentz

Subject: Re: [PATCH Bluez] avcrp: Fix response length for unit info command.

Hi Joohi,

On Mon, Mar 26, 2012 at 3:44 AM, Joohi RASTOGI
<[email protected]> wrote:
> Hi,
>
> Fixed response length for Unit Info command. This affect PTS Test Case for TC_TG_ICC_BV_01_I.
>
> From f03c6037836bf8ef5253f8d87edb8ec2db0742af Mon Sep 17 00:00:00 2001
> From: Joohi Rastogi <[email protected]>
> Date: Mon, 26 Mar 2012 11:53:19 +0530
> Subject: [PATCH Bluez] avcrp: Fix response length for unit info command.
>
> ---
> ?audio/avctp.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/avctp.c b/audio/avctp.c
> index dfad9fd..5b84977 100644
> --- a/audio/avctp.c
> +++ b/audio/avctp.c
> @@ -268,7 +268,7 @@ static size_t handle_unit_info(struct avctp *session,
>
> ? ? ? ?DBG("reply to AVC_OP_UNITINFO");
>
> - ? ? ? return 0;
> + ? ? ? return operand_count;
> ?}
>
> ?static size_t handle_subunit_info(struct avctp *session,
> --
> 1.7.5.4
>
> -Joohi Rastogi

Looks correct, ack. Btw please use uppercase for acronyms such as AVRCP.

--
Luiz Augusto von Dentz