2014-03-25 12:53:00

by Jakub Tyszkowski

Subject: [PATCH 1/2] android/hal-gatt: Fix sending wrong gatt_id struct

---
android/hal-gatt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/hal-gatt.c b/android/hal-gatt.c
index bd61576..8a8ce9c 100644
--- a/android/hal-gatt.c
+++ b/android/hal-gatt.c
@@ -676,7 +676,7 @@ static bt_status_t get_descriptor(int conn_id, btgatt_srvc_id_t *srvc_id,
cmd->number = 1;

if (start_descr_id) {
- gatt_id_to_hal(&cmd->gatt_id[1], char_id);
+ gatt_id_to_hal(&cmd->gatt_id[1], start_descr_id);
len += sizeof(cmd->gatt_id[1]);
cmd->number++;
}
--
1.9.0

2014-03-25 13:07:36

by Szymon Janc

Subject: Re: [PATCH 1/2] android/hal-gatt: Fix sending wrong gatt_id struct

Hi Jakub,

On Tuesday 25 of March 2014 13:53:00 Jakub Tyszkowski wrote:
> ---
> android/hal-gatt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/hal-gatt.c b/android/hal-gatt.c
> index bd61576..8a8ce9c 100644
> --- a/android/hal-gatt.c
> +++ b/android/hal-gatt.c
> @@ -676,7 +676,7 @@ static bt_status_t get_descriptor(int conn_id, btgatt_srvc_id_t *srvc_id,
> cmd->number = 1;
>
> if (start_descr_id) {
> - gatt_id_to_hal(&cmd->gatt_id[1], char_id);
> + gatt_id_to_hal(&cmd->gatt_id[1], start_descr_id);
> len += sizeof(cmd->gatt_id[1]);
> cmd->number++;
> }
>

Both patches applied, thanks.

--
Best regards,
Szymon Janc

2014-03-25 12:53:01

by Jakub Tyszkowski

Subject: [PATCH 2/2] android/hal-gatt: Fix sending get characteristic cmd

---
android/hal-gatt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/hal-gatt.c b/android/hal-gatt.c
index 8a8ce9c..51caf8d 100644
--- a/android/hal-gatt.c
+++ b/android/hal-gatt.c
@@ -646,7 +646,7 @@ static bt_status_t get_characteristic(int conn_id, btgatt_srvc_id_t *srvc_id,
cmd->conn_id = conn_id;

srvc_id_to_hal(&cmd->srvc_id, srvc_id);
- len += sizeof(cmd->srvc_id);
+ cmd->number = 0;

if (start_char_id) {
gatt_id_to_hal(&cmd->gatt_id[0], start_char_id);
--
1.9.0