2020-04-06 21:19:24

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ] gatt: Fix not sending any data when server supports AcquireWrite

From: Luiz Augusto von Dentz <[email protected]>

msg.msg_iovlen should be set to 1 to forward the data received over the
file descriptor.
---
src/gatt-database.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/gatt-database.c b/src/gatt-database.c
index 483c84341..db67dd3f8 100644
--- a/src/gatt-database.c
+++ b/src/gatt-database.c
@@ -2396,6 +2396,7 @@ static int sock_io_send(struct io *io, const void *data, size_t len)

memset(&msg, 0, sizeof(msg));
msg.msg_iov = &iov;
+ msg.msg_iovlen = 1;

return sendmsg(io_get_fd(io), &msg, MSG_NOSIGNAL);
}
--
2.21.1


2020-04-07 07:15:05

by Szymon Janc

[permalink] [raw]
Subject: Re: [PATCH BlueZ] gatt: Fix not sending any data when server supports AcquireWrite

Hi Luiz,

On Monday, 6 April 2020 23:19:03 CEST Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> msg.msg_iovlen should be set to 1 to forward the data received over the
> file descriptor.
> ---
> src/gatt-database.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gatt-database.c b/src/gatt-database.c
> index 483c84341..db67dd3f8 100644
> --- a/src/gatt-database.c
> +++ b/src/gatt-database.c
> @@ -2396,6 +2396,7 @@ static int sock_io_send(struct io *io, const void
> *data, size_t len)
>
> memset(&msg, 0, sizeof(msg));
> msg.msg_iov = &iov;
> + msg.msg_iovlen = 1;
>
> return sendmsg(io_get_fd(io), &msg, MSG_NOSIGNAL);
> }

Applied, thanks.

--
pozdrawiam
Szymon Janc